Attachment 139173 Details for Bug 279031 – Adds the functionality for closing the last view of a part

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Adds the functionality for closing the last view of a part

lastViewClosability (text/plain), 1.43 KB, created by Holger Staudacher

on 2009-06-15 10:17:14 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Holger Staudacher

Created: 2009-06-15 10:17:14 EDT

Size: 1.43 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.design.example
>Index: src/org/eclipse/rap/internal/design/example/business/stacks/ViewStackPresentation.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.ui/org.eclipse.rap.design.example/src/org/eclipse/rap/internal/design/example/business/stacks/ViewStackPresentation.java,v
>retrieving revision 1.3
>diff -u -r1.3 ViewStackPresentation.java
>--- src/org/eclipse/rap/internal/design/example/business/stacks/ViewStackPresentation.java	13 Jun 2009 07:46:39 -0000	1.3
>+++ src/org/eclipse/rap/internal/design/example/business/stacks/ViewStackPresentation.java	15 Jun 2009 13:11:45 -0000
>@@ -354,7 +354,9 @@
>     IWorkbenchWindow window = workbench.getActiveWorkbenchWindow();
>     IWorkbenchPage activePage = window.getActivePage();
>     IWorkbenchPart workbenchPart = getReference( part ).getPart( false );
>-    activePage.activate( workbenchPart );    
>+    if( workbenchPart != null ) {
>+      activePage.activate( workbenchPart );
>+    }
>   }
>   
>   private IWorkbenchPartReference getReference( final IPresentablePart part) {
>@@ -561,6 +563,10 @@
>   public void dispose() {
>     ViewToolBarRegistry registry = ViewToolBarRegistry.getInstance();
>     registry.removeViewPartPresentation( this );
>+    if( toolBarLayer != null ) {
>+      toolBarLayer.dispose();
>+    }
>+    presentationControl.dispose();
>   }
> 
>   public Control getControl() {

Actions: View | Diff

Attachments on bug 279031: 139173