Attachment 139020 Details for Bug 279460 – prevents unwanted native scrolling of Table

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] prevents unwanted native scrolling of Table

ScrollBug.txt (text/plain), 3.22 KB, created by Tim Buschtoens

on 2009-06-12 09:11:40 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Buschtoens

Created: 2009-06-12 09:11:40 EDT

Size: 3.22 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/WidgetUtil.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/WidgetUtil.js,v
>retrieving revision 1.3
>diff -u -r1.3 WidgetUtil.js
>--- js/org/eclipse/swt/WidgetUtil.js	17 Aug 2008 13:19:21 -0000	1.3
>+++ js/org/eclipse/swt/WidgetUtil.js	12 Jun 2009 12:59:35 -0000
>@@ -32,6 +32,67 @@
>         widget.setStyleProperty( "fontSize", "0" );
>         widget.setStyleProperty( "lineHeight", "0" );
>       }
>-    }
>-  }
>+    },
>+    
>+    //----------------- disable scrolling -------------------
>+    
>+    scrollBack : function( widget ) {
>+      var el = widget._getTargetNode();
>+       if( el ) {
>+         this._scrollBack( el );
>+       }
>+    },
>+
>+    disableScrolling : function( widget ) {
>+      var el = widget._getTargetNode();
>+      if( el ) {
>+        this._attachOnscrollEvent( el );
>+      } else {
>+        widget.addEventListener( "appear", this._onElementCreate, this );
>+      }
>+    },
>+    
>+    enableScrolling : function( widget ) {      
>+      var el = widget._getTargetNode();
>+      if( el ) {
>+        this._removeOnscrollEvent( el );
>+      } else {
>+        widget.removeEventListener( "appear", this._onElementCreate, this );
>+      }     
>+    },
>+    
>+    _onElementCreate : function( ev ){
>+      var widget = ev.getTarget();
>+      widget.removeEventListener( "appear", this._onElementCreate, this );
>+      this._attachOnscrollEvent( widget._getTargetNode() );
>+    },
>+    
>+    _attachOnscrollEvent : function( el ) {     
>+      if ( qx.core.Variant.isSet( "qx.client", "mshtml" ) ) {
>+        el.attachEvent( "onscroll", this._onscroll );
>+      } else {
>+        el.addEventListener( "scroll", this._onscroll, false );
>+      }
>+    },
>+    
>+    _removeOnscrollEvent : function( el ) {
>+      if ( qx.core.Variant.isSet( "qx.client", "mshtml" ) ) {
>+        el.detachEvent( "onscroll", this._onscroll );
>+      } else {
>+        el.removeEventListener( "scroll", this._onscroll, false );
>+      }
>+    },
>+    
>+    _onscroll : function( ev ) {
>+      var el = ev.target || ev.srcElement;
>+      org.eclipse.swt.WidgetUtil._scrollBack( el );
>+    },
>+    
>+    _scrollBack : function( el ) {
>+      if( el.scrollLeft != 0 || el.scrollTop != 0 ) {
>+        el.scrollLeft = 0;
>+        el.scrollTop = 0;
>+      }
>+    }       
>+  } 
> });
>\ No newline at end of file
>Index: js/org/eclipse/swt/widgets/Table.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Table.js,v
>retrieving revision 1.51
>diff -u -r1.51 Table.js
>--- js/org/eclipse/swt/widgets/Table.js	4 Jun 2009 11:48:55 -0000	1.51
>+++ js/org/eclipse/swt/widgets/Table.js	12 Jun 2009 12:59:36 -0000
>@@ -136,6 +136,7 @@
>     var widgetManager = org.eclipse.swt.WidgetManager.getInstance();
>     widgetManager.add( this._clientArea, id + "_clientArea", false );
>     this.add( this._clientArea );
>+    org.eclipse.swt.WidgetUtil.disableScrolling( this );    
>   },
> 
>   destruct : function() {

Actions: View | Diff

Attachments on bug 279460: 138566 | 139020 | 139972 | 139973