Attachment 138705 Details for Bug 279132 – Cleaner solution

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Cleaner solution

menuBarItemVisibilityClean (text/plain), 2.49 KB, created by Holger Staudacher

on 2009-06-09 14:50:52 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Holger Staudacher

Created: 2009-06-09 14:50:52 EDT

Size: 2.49 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.design.example
>Index: src/org/eclipse/rap/internal/design/example/business/popups/MenuBarPopup.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.ui/org.eclipse.rap.design.example/src/org/eclipse/rap/internal/design/example/business/popups/MenuBarPopup.java,v
>retrieving revision 1.1
>diff -u -r1.1 MenuBarPopup.java
>--- src/org/eclipse/rap/internal/design/example/business/popups/MenuBarPopup.java	28 May 2009 13:18:24 -0000	1.1
>+++ src/org/eclipse/rap/internal/design/example/business/popups/MenuBarPopup.java	9 Jun 2009 18:51:38 -0000
>@@ -115,24 +115,25 @@
>     layout.marginBottom = 0;
>     content.setLayout( layout );
> 
>-    
>     for( int i = 0; i < items.length; i++ ) {
>       IContributionItem item = items[ i ];
>-      if( item instanceof ActionContributionItem ) {
>-        // Actions
>-        ActionContributionItem actionItem = ( ActionContributionItem ) item;
>-        makeActionEntry( actionItem.getAction(), content );
>-      } else if( item instanceof MenuManager ) {
>-        // MenuManagers
>-        MenuManager manager = ( MenuManager ) item;
>-        makeMenuManagerEntry( manager, content );
>-      } else if( item instanceof CommandContributionItem ) {
>-        // Commands                
>-        CommandContributionItem command = ( CommandContributionItem ) item;
>-        makeCommandEntry( command, content );
>-      } else if( item instanceof ShowViewMenu ) {
>-        // ViewMenu
>-        makeViewEntries( content );
>+      if( item.isVisible() ) {
>+        if( item instanceof ActionContributionItem ) {
>+          // Actions
>+          ActionContributionItem actionItem = ( ActionContributionItem ) item;
>+          makeActionEntry( actionItem.getAction(), content );
>+        } else if( item instanceof MenuManager ) {
>+          // MenuManagers
>+          MenuManager manager = ( MenuManager ) item;
>+          makeMenuManagerEntry( manager, content );
>+        } else if( item instanceof CommandContributionItem ) {
>+          // Commands                
>+          CommandContributionItem command = ( CommandContributionItem ) item;
>+          makeCommandEntry( command, content );
>+        } else if( item instanceof ShowViewMenu ) {
>+          // ViewMenu
>+          makeViewEntries( content );
>+        }
>       }
>     }
> 
>@@ -283,7 +284,7 @@
>         public void widgetDisposed( DisposeEvent event ) {
>           destroyItem( item );
>         }
>-      } );
>+      } );      
>     }
>     
>   }

Actions: View | Diff

Attachments on bug 279132: 138602 | 138705 | 139187