Attachment 137972 Details for Bug 278361 – Proposed patch.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch.

Bug-278361.patch (text/plain), 1.35 KB, created by Ivan Furnadjiev

on 2009-06-02 05:10:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2009-06-02 05:10:26 EDT

Size: 1.35 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.20
>diff -u -r1.20 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	25 May 2009 11:28:14 -0000	1.20
>+++ js/org/eclipse/swt/widgets/Combo.js	2 Jun 2009 09:02:39 -0000
>@@ -647,12 +647,26 @@
>         req.addParameter( id + ".selectionLength", length );
>       }
>     },
>+    
>+    // [if] Workaround for bug:
>+    // 278361: [Combo] Overlays text after changing items
>+    // https://bugs.eclipse.org/bugs/show_bug.cgi?id=278361
>+    // Items are not removed from DOM if the _isDisplayable property is false.
>+    _removeAll : function() {
>+      var items = this._list.getChildren();
>+      var item = items.length > 0 ? items[ 0 ] : null;
>+      while( item != null ) {
>+        item._isDisplayable = true;
>+        item.destroy();
>+        item = items.length > 0 ? items[ 0 ] : null;
>+      }
>+    },
> 
>     //////////////
>     // Set methods
>     
>     setItems : function( items ) {
>-      this._list.removeAll();
>+      this._removeAll();
>       for( var i = 0; i < items.length; i++ ) {
>         var item = new qx.ui.form.ListItem();
>         item.setLabel( "(empty)" );

Flags:

ivan: review?

Actions: View | Diff

Attachments on bug 278361: 137620 | 137621 | 137629 | 137649 | 137972