Attachment #137972 for bug #278361

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.




        req.addParameter( id + ".selectionLength", length );
      }
    },
    
    // [if] Workaround for bug:
    // 278361: [Combo] Overlays text after changing items
    // https://bugs.eclipse.org/bugs/show_bug.cgi?id=278361
    // Items are not removed from DOM if the _isDisplayable property is false.
    _removeAll : function() {
      var items = this._list.getChildren();
      var item = items.length > 0 ? items[ 0 ] : null;
      while( item != null ) {
        item._isDisplayable = true;
        item.destroy();
        item = items.length > 0 ? items[ 0 ] : null;
      }
    },

    //////////////
    // Set methods
    
    setItems : function( items ) {
      this._removeAll();
      for( var i = 0; i < items.length; i++ ) {
        var item = new qx.ui.form.ListItem();
        item.setLabel( "(empty)" );

Return to bug 278361

Lines 647-658 Link Here

(-)js/org/eclipse/swt/widgets/Combo.js (-1 / +15 lines)
647	req.addParameter( id + ".selectionLength", length );	647	req.addParameter( id + ".selectionLength", length );
648	}	648	}
649	},	649	},
		650
		651	// [if] Workaround for bug:
		652	// 278361: [Combo] Overlays text after changing items
		653	// https://bugs.eclipse.org/bugs/show_bug.cgi?id=278361
		654	// Items are not removed from DOM if the _isDisplayable property is false.
		655	_removeAll : function() {
		656	var items = this._list.getChildren();
		657	var item = items.length > 0 ? items[ 0 ] : null;
		658	while( item != null ) {
		659	item._isDisplayable = true;
		660	item.destroy();
		661	item = items.length > 0 ? items[ 0 ] : null;
		662	}
		663	},
650		664
651	//////////////	665	//////////////
652	// Set methods	666	// Set methods
653		667
654	setItems : function( items ) {	668	setItems : function( items ) {
655	this._list.removeAll();	669	this._removeAll();
656	for( var i = 0; i < items.length; i++ ) {	670	for( var i = 0; i < items.length; i++ ) {
657	var item = new qx.ui.form.ListItem();	671	var item = new qx.ui.form.ListItem();
658	item.setLabel( "(empty)" );	672	item.setLabel( "(empty)" );