Attachment 137756 Details for Bug 278522 – Patch to avoid NPE, added null check

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to avoid NPE, added null check

clipboard.txt (text/plain), 1.46 KB, created by David Shepherd

on 2009-05-30 13:36:45 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Shepherd

Created: 2009-05-30 13:36:45 EDT

Size: 1.46 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java,v
>retrieving revision 1.172
>diff -u -r1.172 TaskPlanningEditor.java
>--- src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java	28 May 2009 23:02:22 -0000	1.172
>+++ src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskPlanningEditor.java	30 May 2009 17:37:25 -0000
>@@ -259,15 +259,17 @@
> 	}
> 
> 	public void refresh() {
>-		getEditor().updateHeaderToolBar();
>-		IFormPart[] parts = getManagedForm().getParts();
>-		// refresh will not be invoked unless parts are stale
>-		for (IFormPart part : parts) {
>-			if (part instanceof AbstractLocalEditorPart) {
>-				((AbstractLocalEditorPart) part).markStale();
>+		if (getEditor().getHeaderForm() != null) {
>+			getEditor().updateHeaderToolBar();
>+			IFormPart[] parts = getManagedForm().getParts();
>+			// refresh will not be invoked unless parts are stale
>+			for (IFormPart part : parts) {
>+				if (part instanceof AbstractLocalEditorPart) {
>+					((AbstractLocalEditorPart) part).markStale();
>+				}
> 			}
>+			getManagedForm().refresh();
> 		}
>-		getManagedForm().refresh();
> 	}
> 
> 	public void fillLeftHeaderToolBar(IToolBarManager toolBarManager) {

Actions: View | Diff

Attachments on bug 278522: 137756 | 137936