Attachment 136163 Details for Bug 276480 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug276480-patch_2009-05-17.txt (text/plain), 3.07 KB, created by Asen Draganov

on 2009-05-18 04:42:49 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Asen Draganov

Created: 2009-05-18 04:42:49 EDT

Size: 3.07 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.16
>diff -u -r1.16 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	12 May 2009 11:38:59 -0000	1.16
>+++ js/org/eclipse/swt/widgets/Combo.js	17 May 2009 19:45:06 -0000
>@@ -46,7 +46,7 @@
>     this._list = new qx.ui.form.List();
>     this._list.setAppearance( "combo-list" );
>     this._list.setTabIndex( -1 );
>-    this._list.setVisibility( false );
>+    this._list.setDisplay( false );
>     // List Manager
>     this._manager = this._list.getManager();
>     this._manager.setMultiSelection( false );
>@@ -126,7 +126,7 @@
>   members : {
>     _onChangeSize : function( evt ) {
>       this._list.setWidth( this.getWidth() );
>-      this._listPositioning();
>+      this._setListLocation();
>     },
> 
>     _onAppear : function( evt ) {
>@@ -141,6 +141,7 @@
>         this._list.addState( "rwt_FLAT" );
>       }
>       this.getTopLevelWidget().add( this._list );
>+      this._setListLocation();
>     },
>     
>     _onFocusIn : function( evt ) {
>@@ -223,9 +224,11 @@
>         this._toggleListVisibility();
>       }
>     },
>-    
>+
>+    ///////////////////////////////////////
>     // List and list-items handling methods
>-    _listPositioning : function() {
>+
>+    _setListLocation : function() {
>       if( this.getElement() ){
>         var elementPos = qx.bom.element.Location.get( this.getElement() );
>         this._list.setLocation( elementPos.left,
>@@ -234,7 +237,6 @@
>     },
>     
>     _toggleListVisibility : function() {
>-      this._listPositioning();
>       if( this._list.getChildrenLength() ) {
>         // Temporary make the text field ReadOnly, when the list is dropped.
>         if( this._editable ) {
>@@ -244,10 +246,11 @@
>           // Brings this widget on top of the others with same parent.
>           this._bringToFront();
>           this.setCapture( true );
>+          this._setListLocation();
>         } else {
>           this.setCapture( false );
>         }
>-        this._list.setVisibility( !this._dropped );
>+        this._list.setDisplay( !this._dropped );
>         this._dropped = !this._dropped;
>         if( this.hasState( "rwt_CCOMBO" ) ) {
>           this._updateListVisibleRequestParam();
>@@ -597,7 +600,7 @@
>         var widgetManager = org.eclipse.swt.WidgetManager.getInstance();
>         var req = org.eclipse.swt.Request.getInstance();
>         var id = widgetManager.findIdByWidget( this );
>-        req.addParameter( id + ".listVisible", this._list.getVisibility() );
>+        req.addParameter( id + ".listVisible", this._list.getDisplay() );
>       }
>     },
>     
>@@ -675,7 +678,7 @@
>     },
>     
>     setListVisible : function( value ) {
>-      if( this._list.setVisibility != value ) {
>+      if( this._list.getDisplay() != value ) {
>         this._dropped = !value;
>         this._toggleListVisibility();
>       }

Actions: View | Diff

Attachments on bug 276480: 136163