Attachment 135976 Details for Bug 276479 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug276479-patch_2009-05-15.txt (text/plain), 1.77 KB, created by Asen Draganov

on 2009-05-15 09:07:55 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Asen Draganov

Created: 2009-05-15 09:07:55 EDT

Size: 1.77 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.16
>diff -u -r1.16 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	12 May 2009 11:38:59 -0000	1.16
>+++ js/org/eclipse/swt/widgets/Combo.js	15 May 2009 12:37:46 -0000
>@@ -144,7 +144,8 @@
>     },
>     
>     _onFocusIn : function( evt ) {
>-      if(    this.hasState( "rwt_CCOMBO" )
>+      if(    this._field.isCreated()
>+          && this.hasState( "rwt_CCOMBO" )
>           && !org_eclipse_rap_rwt_EventUtil_suspend )
>       {
>         this._handleSelectionChange();
>@@ -371,12 +372,13 @@
>         }
>       }
>     },
>-
>+    
>     _onMouseUp : function( evt ) {
>       if( !this._dropped ) {
>         this.setCapture( false );
>       }
>-      if(    this.hasState( "rwt_CCOMBO" )
>+      if(    evt.getTarget() == this._field
>+          && this.hasState( "rwt_CCOMBO" )
>           && !org_eclipse_rap_rwt_EventUtil_suspend ) 
>       {
>         this._handleSelectionChange();
>@@ -456,7 +458,8 @@
>           }
>           break;
>       }
>-      if(    this.hasState( "rwt_CCOMBO" )
>+      if(    this._field.isCreated()
>+          && this.hasState( "rwt_CCOMBO" )
>           && !org_eclipse_rap_rwt_EventUtil_suspend ) 
>       {
>         this._handleSelectionChange();
>@@ -520,7 +523,8 @@
>             }
>           }
>       }
>-      if(    this.hasState( "rwt_CCOMBO" )
>+      if(    this._field.isCreated()
>+          && this.hasState( "rwt_CCOMBO" )
>           && !org_eclipse_rap_rwt_EventUtil_suspend ) 
>       {
>         this._handleSelectionChange();

Actions: View | Diff

Attachments on bug 276479: 135976