Attachment 135975 Details for Bug 276473 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

Bug276473-patch_2009-05-15.txt (text/plain), 1.71 KB, created by Asen Draganov

on 2009-05-15 09:07:22 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Asen Draganov

Created: 2009-05-15 09:07:22 EDT

Size: 1.71 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.16
>diff -u -r1.16 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	12 May 2009 11:38:59 -0000	1.16
>+++ js/org/eclipse/swt/widgets/Combo.js	15 May 2009 13:07:24 -0000
>@@ -67,6 +67,7 @@
>     this.addEventListener( "changeBackgroundColor",
>                            this._onChangeBackgoundColor, 
>                            this );
>+    this.addEventListener( "changeVisibility", this._onChangeVisibility, this );
>     // Mouse events
>     this.addEventListener( "mousedown", this._onMouseDown, this );
>     this.addEventListener( "mouseup", this._onMouseUp, this );
>@@ -96,6 +97,7 @@
>     this.removeEventListener( "changeBackgroundColor",
>                               this._onChangeBackgoundColor, 
>                               this );
>+    this.removeEventListener( "changeVisibility", this._onChangeVisibility, this );
>     this.removeEventListener( "mousedown", this._onMouseDown, this );
>     this.removeEventListener( "mouseup", this._onMouseUp, this );
>     this.removeEventListener( "click", this._onMouseClick, this );
>@@ -182,6 +184,13 @@
>       this._list.setBackgroundColor( value );
>     },
>     
>+    _onChangeVisibility : function( evt ) {
>+      var value = evt.getValue();
>+      if( !value && this._dropped ) {
>+        this._toggleListVisibility();
>+      }
>+    },
>+    
>     _applyCursor : function( value, old ) {
>       this.base( arguments, value, old );
>       if( value ) {

Actions: View | Diff

Attachments on bug 276473: 135968 | 135975