Attachment 135396 Details for Bug 275479 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

bug275479.patch (text/plain), 2.05 KB, created by Susan McCourt

on 2009-05-12 12:43:06 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Susan McCourt

Created: 2009-05-12 12:43:06 EDT

Size: 2.05 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.equinox.p2.ui
>Index: src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/RepositoryManipulationPage.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/RepositoryManipulationPage.java,v
>retrieving revision 1.16
>diff -u -r1.16 RepositoryManipulationPage.java
>--- src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/RepositoryManipulationPage.java	6 May 2009 23:22:35 -0000	1.16
>+++ src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/RepositoryManipulationPage.java	12 May 2009 16:42:35 -0000
>@@ -22,6 +22,7 @@
> import org.eclipse.equinox.internal.p2.ui.viewers.MetadataRepositoryElementComparator;
> import org.eclipse.equinox.internal.p2.ui.viewers.RepositoryDetailsLabelProvider;
> import org.eclipse.equinox.internal.provisional.p2.core.ProvisionException;
>+import org.eclipse.equinox.internal.provisional.p2.repository.IRepository;
> import org.eclipse.equinox.internal.provisional.p2.repository.RepositoryEvent;
> import org.eclipse.equinox.internal.provisional.p2.ui.*;
> import org.eclipse.equinox.internal.provisional.p2.ui.model.MetadataRepositories;
>@@ -576,6 +577,18 @@
> 							}
> 							// stop swallowing events
> 							ProvUI.endBatchOperation(false);
>+						} else {
>+							// see https://bugs.eclipse.org/bugs/show_bug.cgi?id=275479
>+							// Refreshing the repo will lose any nickname that was previously
>+							// set.  We reset it back in the manager.  We must do this directly
>+							// so that the right thing happens even when the user cancels the page.
>+							String nickname = selected[0].getName();
>+							if (nickname != null && nickname.length() > 0)
>+								try {
>+									ProvisioningUtil.setMetadataRepositoryProperty(location, IRepository.PROP_NICKNAME, nickname);
>+								} catch (ProvisionException e) {
>+									ProvUI.handleException(e, null, StatusManager.SHOW);
>+								}
> 						}
> 					}
> 				}

Actions: View | Diff

Attachments on bug 275479: 135396 | 135664