Attachment 135272 Details for Bug 185817 – Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch

TableDoubleClick.txt (text/plain), 2.45 KB, created by Praveen

on 2009-05-12 01:51:42 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Praveen

Created: 2009-05-12 01:51:42 EDT

Size: 2.45 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.swt
>Index: Eclipse SWT/gtk/org/eclipse/swt/widgets/Table.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Table.java,v
>retrieving revision 1.272
>diff -u -r1.272 Table.java
>--- Eclipse SWT/gtk/org/eclipse/swt/widgets/Table.java	2 Apr 2009 20:23:34 -0000	1.272
>+++ Eclipse SWT/gtk/org/eclipse/swt/widgets/Table.java	12 May 2009 05:28:18 -0000
>@@ -1909,8 +1909,9 @@
> 	* not in focus and all items in the widget are disposed before
> 	* it finishes processing a button press.  The fix is to give
> 	* focus to the widget before it starts processing the event.
>+	* This fix should not be applied for double-click events.
> 	*/
>-	if (!OS.GTK_WIDGET_HAS_FOCUS (handle)) {
>+	if (!OS.GTK_WIDGET_HAS_FOCUS (handle) && gdkEvent.type == OS.GDK_BUTTON_PRESS) {
> 		OS.gtk_widget_grab_focus (handle);
> 	}
> 	return result;
>Index: Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java,v
>retrieving revision 1.124
>diff -u -r1.124 List.java
>--- Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java	5 Jun 2008 17:31:07 -0000	1.124
>+++ Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java	12 May 2009 05:28:16 -0000
>@@ -768,7 +768,7 @@
> 	* it finishes processing a button press.  The fix is to give
> 	* focus to the widget before it starts processing the event.
> 	*/
>-	if (!OS.GTK_WIDGET_HAS_FOCUS (handle)) {
>+	if (!OS.GTK_WIDGET_HAS_FOCUS (handle) && gdkEvent.type == OS.GDK_BUTTON_PRESS) {
> 		OS.gtk_widget_grab_focus (handle);
> 	}
> 	return result;
>Index: Eclipse SWT/gtk/org/eclipse/swt/widgets/Tree.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Tree.java,v
>retrieving revision 1.262
>diff -u -r1.262 Tree.java
>--- Eclipse SWT/gtk/org/eclipse/swt/widgets/Tree.java	22 Apr 2009 15:12:00 -0000	1.262
>+++ Eclipse SWT/gtk/org/eclipse/swt/widgets/Tree.java	12 May 2009 05:28:19 -0000
>@@ -1908,7 +1908,7 @@
> 	* it finishes processing a button press.  The fix is to give
> 	* focus to the widget before it starts processing the event.
> 	*/
>-	if (!OS.GTK_WIDGET_HAS_FOCUS (handle)) {
>+	if (!OS.GTK_WIDGET_HAS_FOCUS (handle) && gdkEvent.type == OS.GDK_BUTTON_PRESS) {
> 		OS.gtk_widget_grab_focus (handle);
> 	}
> 	return result;

Actions: View | Diff

Attachments on bug 185817: 66160 | 135272