Attachment 134716 Details for Bug 275233 – patch that fixes the problem

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch that fixes the problem

275233.txt (text/plain), 2.38 KB, created by Henrik Lindberg

on 2009-05-06 20:16:35 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Henrik Lindberg

Created: 2009-05-06 20:16:35 EDT

Size: 2.38 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.equinox.p2.repository
>Index: src/org/eclipse/equinox/internal/p2/repository/Credentials.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.repository/src/org/eclipse/equinox/internal/p2/repository/Credentials.java,v
>retrieving revision 1.6
>diff -u -r1.6 Credentials.java
>--- src/org/eclipse/equinox/internal/p2/repository/Credentials.java	28 Apr 2009 00:27:12 -0000	1.6
>+++ src/org/eclipse/equinox/internal/p2/repository/Credentials.java	7 May 2009 00:03:29 -0000
>@@ -30,6 +30,11 @@
>  * in a store, if none is provided the user is optionally prompted for the information. 
>  */
> public class Credentials {
>+	public static class LoginCanceledException extends Exception {
>+		private static final long serialVersionUID = 1L;
>+
>+	}
>+
> 	private static final Map savedAuthInfo = Collections.synchronizedMap(new HashMap());
> 
> 	/**
>@@ -48,7 +53,7 @@
> 	 * @throws CoreException if the password cannot be read or saved
> 	 * @return The authentication info.
> 	 */
>-	public static AuthenticationInfo forLocation(URI location, boolean prompt) throws UserCancelledException, CoreException {
>+	public static AuthenticationInfo forLocation(URI location, boolean prompt) throws LoginCanceledException, CoreException {
> 		return forLocation(location, prompt, null);
> 	}
> 
>@@ -70,7 +75,7 @@
> 	 * @throws UserCancelledException - user canceled the prompt for name/password
> 	 * @throws CoreException if there is an error
> 	 */
>-	public static AuthenticationInfo forLocation(URI location, boolean prompt, AuthenticationInfo lastUsed) throws UserCancelledException, CoreException {
>+	public static AuthenticationInfo forLocation(URI location, boolean prompt, AuthenticationInfo lastUsed) throws LoginCanceledException, CoreException {
> 		ISecurePreferences securePreferences = SecurePreferencesFactory.getDefault();
> 
> 		// if URI is not opaque, just getting the host may be enough
>@@ -137,7 +142,7 @@
> 			loginDetails = lastUsed != null ? adminUIService.getUsernamePassword(host, lastUsed) : adminUIService.getUsernamePassword(host);
> 		//null result means user canceled password dialog
> 		if (loginDetails == null)
>-			throw new UserCancelledException();
>+			throw new LoginCanceledException();
> 		//save user name and password if requested by user
> 		if (loginDetails.saveResult()) {
> 			if (prefNode == null)

Actions: View | Diff

Attachments on bug 275233: 134716 | 134717 | 134763