Attachment 134659 Details for Bug 147044 – updated fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] updated fix

147044B.patch (text/plain), 9.18 KB, created by Michael Rennie

on 2009-05-06 13:55:09 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Rennie

Created: 2009-05-06 13:55:09 EDT

Size: 9.18 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ant.ui
>Index: Ant Tools Support/org/eclipse/ant/internal/ui/launchConfigurations/AntJRETab.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ant.ui/Ant Tools Support/org/eclipse/ant/internal/ui/launchConfigurations/AntJRETab.java,v
>retrieving revision 1.43
>diff -u -r1.43 AntJRETab.java
>--- Ant Tools Support/org/eclipse/ant/internal/ui/launchConfigurations/AntJRETab.java	13 Aug 2008 15:32:18 -0000	1.43
>+++ Ant Tools Support/org/eclipse/ant/internal/ui/launchConfigurations/AntJRETab.java	6 May 2009 17:55:00 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2008 IBM Corporation and others.
>+ * Copyright (c) 2000, 2009 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -11,7 +11,6 @@
> 
> package org.eclipse.ant.internal.ui.launchConfigurations;
> 
>-import org.eclipse.ant.internal.ui.AntUIPlugin;
> import org.eclipse.ant.internal.ui.IAntUIConstants;
> import org.eclipse.ant.internal.ui.IAntUIHelpContextIds;
> import org.eclipse.ant.ui.launching.IAntLaunchConfigurationConstants;
>@@ -20,6 +19,7 @@
> import org.eclipse.debug.core.ILaunchConfiguration;
> import org.eclipse.debug.core.ILaunchConfigurationWorkingCopy;
> import org.eclipse.debug.ui.ILaunchConfigurationDialog;
>+import org.eclipse.jdt.core.IJavaProject;
> import org.eclipse.jdt.debug.ui.launchConfigurations.JavaJRETab;
> import org.eclipse.jdt.internal.debug.ui.jres.JREDescriptor;
> import org.eclipse.jdt.internal.debug.ui.launcher.VMArgumentsBlock;
>@@ -91,22 +91,17 @@
> 		boolean isDefaultJRE = fJREBlock.isDefaultJRE();
>         fWorkingDirectoryBlock.setEnabled(!isDefaultJRE);
> 		fVMArgumentsBlock.setEnabled(!isDefaultJRE);
>+		configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_NAME, (String)null);
>+		configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_TYPE, (String)null);
> 		if (isDefaultJRE) {
>-			configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_NAME, (String)null);
>-			configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_TYPE, (String)null);
> 			configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_JRE_CONTAINER_PATH, (String)null);
> 			configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_MAIN_TYPE_NAME, (String)null);
> 			configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_PROGRAM_ARGUMENTS, (String)null);
> 			configuration.setAttribute(IAntLaunchConfigurationConstants.ATTR_DEFAULT_VM_INSTALL, false);
> 		} else {
> 			super.performApply(configuration);
>-			
>-			if (useDefaultSeparateJRE(configuration)) {
>-				configuration.setAttribute(IAntLaunchConfigurationConstants.ATTR_DEFAULT_VM_INSTALL, true);
>-			} else {
>-				configuration.setAttribute(IAntLaunchConfigurationConstants.ATTR_DEFAULT_VM_INSTALL, false);
>-			}
>-			
>+			IVMInstall vm = fJREBlock.getJRE();
>+			configuration.setAttribute(IAntLaunchConfigurationConstants.ATTR_DEFAULT_VM_INSTALL, (vm == null ? false : vm.equals(getDefaultVMInstall(configuration))));
> 			applySeparateVMAttributes(configuration);
> 			fVMArgumentsBlock.performApply(configuration);
> 			fWorkingDirectoryBlock.performApply(configuration);
>@@ -114,36 +109,6 @@
> 		setLaunchConfigurationWorkingCopy(configuration);
> 	}
> 	
>-	private boolean useDefaultSeparateJRE(ILaunchConfigurationWorkingCopy configuration) {
>-		boolean deflt= false;
>-		String vmInstallType= null;
>-        String jreContainerPath= null;
>-		try {
>-			vmInstallType= configuration.getAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_TYPE, (String)null);
>-            jreContainerPath= configuration.getAttribute(IJavaLaunchConfigurationConstants.ATTR_JRE_CONTAINER_PATH, (String)null);
>-		} catch (CoreException e) {
>-		}
>-		if (vmInstallType != null) {
>-			configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_TYPE, (String)null);
>-		}
>-        if (jreContainerPath != null) {
>-            configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_JRE_CONTAINER_PATH, (String)null);
>-        }
>-		IVMInstall defaultVMInstall= getDefaultVMInstall(configuration);
>-		if (defaultVMInstall != null) {
>-			IVMInstall vm= fJREBlock.getJRE();
>-			deflt= defaultVMInstall.equals(vm);
>-		}
>-		
>-		if (vmInstallType != null) {
>-			configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_TYPE, vmInstallType);
>-		}
>-        if (jreContainerPath != null) {
>-            configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_JRE_CONTAINER_PATH, jreContainerPath);
>-        }
>-		return deflt;
>-	}
>-	
> 	private void applySeparateVMAttributes(ILaunchConfigurationWorkingCopy configuration) {
> 		configuration.setAttribute(IJavaLaunchConfigurationConstants.ATTR_MAIN_TYPE_NAME, MAIN_TYPE_NAME);
> 		//only set to use the remote ant process factory if the user
>@@ -173,35 +138,10 @@
> 	 * @see org.eclipse.debug.ui.ILaunchConfigurationTab#initializeFrom(org.eclipse.debug.core.ILaunchConfiguration)
> 	 */
> 	public void initializeFrom(ILaunchConfiguration configuration) {
>-		try {
>-			 boolean isDefaultVMInstall= configuration.getAttribute(IAntLaunchConfigurationConstants.ATTR_DEFAULT_VM_INSTALL, false);
>-			 if (isDefaultVMInstall) {
>-			 	ILaunchConfigurationWorkingCopy copy = null;
>-			 	if (configuration instanceof ILaunchConfigurationWorkingCopy) {
>-			 		copy= (ILaunchConfigurationWorkingCopy) configuration;
>-			 	} else {
>-			 		copy= configuration.getWorkingCopy();
>-			 	}
>-			 	
>-			 	//null out the vm type and jre container path to get the default vm install from JavaRuntime
>-			 	copy.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_TYPE, (String)null);
>-			 	copy.setAttribute(IJavaLaunchConfigurationConstants.ATTR_JRE_CONTAINER_PATH, (String)null);
>-			 	IVMInstall defaultVMInstall= getDefaultVMInstall(copy);
>-			 	if (defaultVMInstall != null) {
>-			 		//update if required
>-			 		setDefaultVMInstallAttributes(defaultVMInstall, copy);
>-			 	}
>-				if (copy.isDirty() && !copy.isReadOnly()) {
>-					configuration= copy.doSave();
>-				}
>-			 }
>-        } catch (CoreException ce) {
>-        	AntUIPlugin.log(ce);
>-        }
> 		super.initializeFrom(configuration);
> 		fVMArgumentsBlock.initializeFrom(configuration);
> 		fWorkingDirectoryBlock.initializeFrom(configuration);
>-		boolean separateVM= !fJREBlock.isDefaultJRE();
>+		boolean separateVM = !fJREBlock.isDefaultJRE();
> 		fWorkingDirectoryBlock.setEnabled(separateVM);
> 		fVMArgumentsBlock.setEnabled(separateVM);
> 	}
>@@ -257,36 +197,39 @@
> 	public void setDefaults(ILaunchConfigurationWorkingCopy config) {
> 		super.setDefaults(config);
> 		config.setAttribute(IJavaLaunchConfigurationConstants.ATTR_SOURCE_PATH_PROVIDER, "org.eclipse.ant.ui.AntClasspathProvider"); //$NON-NLS-1$
>-		IVMInstall defaultVMInstall= getDefaultVMInstall(config);
>+		IVMInstall defaultVMInstall = getDefaultVMInstall(config);
> 		if (defaultVMInstall != null) {
> 			config.setAttribute(IAntLaunchConfigurationConstants.ATTR_DEFAULT_VM_INSTALL, true);
>-			setDefaultVMInstallAttributes(defaultVMInstall, config);
>+			//setDefaultVMInstallAttributes(defaultVMInstall, config);
> 			applySeparateVMAttributes(config);
> 		}
> 		
> 	}
> 
>+	/**
>+	 * Returns the default {@link IVMInstall} for the given {@link ILaunchConfiguration}, which resolves
>+	 * to the {@link IVMInstall} for the backing {@link IJavaProject} as specified by the project
>+	 * attribute in the configuration. If there is no project attribute the workspace default
>+	 * {@link IVMInstall} is returned.
>+	 * 
>+	 * @param config
>+	 * @return the default {@link IVMInstall} for the given {@link ILaunchConfiguration}
>+	 */
> 	private IVMInstall getDefaultVMInstall(ILaunchConfiguration config) {
>-		IVMInstall defaultVMInstall;
> 		try {
>-			defaultVMInstall = JavaRuntime.computeVMInstall(config);
>+			IJavaProject project = JavaRuntime.getJavaProject(config);
>+			if(project != null) {
>+				return JavaRuntime.getVMInstall(project);
>+			}
>+			return JavaRuntime.getDefaultVMInstall();
> 		} catch (CoreException e) {
> 			//core exception thrown for non-Java project
>-			defaultVMInstall= JavaRuntime.getDefaultVMInstall();
>+			return JavaRuntime.getDefaultVMInstall();
> 		}
>-		return defaultVMInstall;
>-	}
>-
>-	private void setDefaultVMInstallAttributes(IVMInstall defaultVMInstall, ILaunchConfigurationWorkingCopy config) {
>-		String vmName = defaultVMInstall.getName();
>-		String vmTypeID = defaultVMInstall.getVMInstallType().getId();
>-		config.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_NAME, vmName);
>-		config.setAttribute(IJavaLaunchConfigurationConstants.ATTR_VM_INSTALL_TYPE, vmTypeID);
> 	}
> 	
> 	/* (non-Javadoc)
> 	 * @see org.eclipse.debug.ui.ILaunchConfigurationTab#deactivated(org.eclipse.debug.core.ILaunchConfigurationWorkingCopy)
> 	 */
>-	public void deactivated(ILaunchConfigurationWorkingCopy workingCopy) {
>-	}
>+	public void deactivated(ILaunchConfigurationWorkingCopy workingCopy) {}
> }

Actions: View | Diff

Attachments on bug 147044: 73576 | 134659 | 163007