Attachment 134283 Details for Bug 273498 – proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed fix

273498.patch (text/plain), 1.71 KB, created by Michael Rennie

on 2009-05-04 14:26:45 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Rennie

Created: 2009-05-04 14:26:45 EDT

Size: 1.71 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.debug.core
>Index: core/org/eclipse/debug/internal/core/LaunchConfiguration.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchConfiguration.java,v
>retrieving revision 1.115
>diff -u -r1.115 LaunchConfiguration.java
>--- core/org/eclipse/debug/internal/core/LaunchConfiguration.java	20 Jan 2009 16:39:44 -0000	1.115
>+++ core/org/eclipse/debug/internal/core/LaunchConfiguration.java	4 May 2009 18:26:28 -0000
>@@ -199,8 +199,7 @@
> 		Exception ex = null;
> 		try {
> 			Element root = null;
>-			DocumentBuilder parser =
>-				DocumentBuilderFactory.newInstance().newDocumentBuilder();
>+			DocumentBuilder parser = DocumentBuilderFactory.newInstance().newDocumentBuilder();
> 			parser.setErrorHandler(new DefaultHandler());
> 			StringReader reader = new StringReader(memento);
> 			InputSource source = new InputSource(reader);
>@@ -210,14 +209,13 @@
> 			String path = root.getAttribute(IConfigurationElementConstants.PATH);
> 
> 			String message = null;				
>-			if (path == null) {
>+			if (path == null || IInternalDebugCoreConstants.EMPTY_STRING.equals(path)) {
> 				message = DebugCoreMessages.LaunchConfiguration_18;  
>-			} else if (localString == null) {
>+			} else if (localString == null || IInternalDebugCoreConstants.EMPTY_STRING.equals(localString)) {
> 				message = DebugCoreMessages.LaunchConfiguration_19;  
> 			}
> 			if (message != null) {
>-				IStatus s = newStatus(message, DebugException.INTERNAL_ERROR, null);
>-				throw new CoreException(s);
>+				throw new CoreException(newStatus(message, DebugException.INTERNAL_ERROR, null));
> 			}
> 			
>

Actions: View | Diff

Attachments on bug 273498: 133109 | 134283