Attachment 133332 Details for Bug 86248 – Fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Fix

86248_patch.txt (text/plain), 5.22 KB, created by Markus Keller

on 2009-04-27 05:54:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Markus Keller

Created: 2009-04-27 05:54:26 EDT

Size: 5.22 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java
>===================================================================
>RCS file: Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java
>diff -N Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ Eclipse UI/org/eclipse/ui/internal/handlers/TraversePageHandler.java	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,71 @@
>+/*******************************************************************************
>+ * Copyright (c) 2004, 2009 IBM Corporation and others.
>+ * All rights reserved. This program and the accompanying materials
>+ * are made available under the terms of the Eclipse Public License v1.0
>+ * which accompanies this distribution, and is available at
>+ * http://www.eclipse.org/legal/epl-v10.html
>+ *
>+ * Contributors:
>+ *     IBM Corporation - initial API and implementation
>+ *******************************************************************************/
>+package org.eclipse.ui.internal.handlers;
>+
>+import java.lang.reflect.Method;
>+
>+import org.eclipse.core.commands.ExecutionEvent;
>+
>+import org.eclipse.swt.SWT;
>+import org.eclipse.swt.widgets.Control;
>+import org.eclipse.swt.widgets.Display;
>+import org.eclipse.swt.widgets.Shell;
>+
>+/**
>+ * This handler is an adaptation of the widget method handler that implements
>+ * page traversal via {@link SWT#TRAVERSE_PAGE_NEXT} and
>+ * {@link SWT#TRAVERSE_PAGE_PREVIOUS} events.
>+ * 
>+ * @since 3.5
>+ */
>+public class TraversePageHandler extends WidgetMethodHandler {
>+
>+	/**
>+	 * The parameters for traverse(int).
>+	 */
>+	private static final Class[] METHOD_PARAMETERS = { int.class };
>+
>+	public final Object execute(final ExecutionEvent event) {
>+		Control focusControl = Display.getCurrent().getFocusControl();
>+		if (focusControl != null) {
>+			int traversal= "next".equals(methodName) ? SWT.TRAVERSE_PAGE_NEXT : SWT.TRAVERSE_PAGE_PREVIOUS; //$NON-NLS-1$
>+			Control control = focusControl;
>+			do {
>+				if (control.traverse (traversal))
>+					return null;
>+				if (control instanceof Shell)
>+					return null;
>+				control = control.getParent();
>+			} while (control != null);
>+		}
>+
>+		return null;
>+	}
>+
>+	/**
>+	 * Looks up the traverse(int) method on the given focus control.
>+	 * 
>+	 * @return The method on the focus control; <code>null</code> if none.
>+	 */
>+	protected Method getMethodToExecute() {
>+		final Control focusControl = Display.getCurrent().getFocusControl();
>+		if (focusControl != null) {
>+			try {
>+				return focusControl.getClass().getMethod("traverse", //$NON-NLS-1$
>+						METHOD_PARAMETERS);
>+			} catch (NoSuchMethodException e) {
>+				// Do nothing.
>+			}
>+		}
>+		return null;
>+	}
>+
>+}
>#P org.eclipse.ui
>Index: plugin.xml
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui/plugin.xml,v
>retrieving revision 1.442
>diff -u -r1.442 plugin.xml
>--- plugin.xml	13 Apr 2009 21:50:35 -0000	1.442
>+++ plugin.xml	27 Apr 2009 09:52:34 -0000
>@@ -1156,6 +1156,20 @@
>             name="%command.previousPage.name">
>       </command>
>       <command
>+            description="%command.nextTab.description"
>+            id="org.eclipse.ui.navigate.nextTab"
>+            categoryId="org.eclipse.ui.category.navigate"
>+            name="%command.nextTab.name"
>+            defaultHandler="org.eclipse.ui.internal.handlers.TraversePageHandler:next">
>+      </command>
>+      <command
>+            description="%command.previousTab.description"
>+            id="org.eclipse.ui.navigate.previousTab"
>+            categoryId="org.eclipse.ui.category.navigate"
>+            name="%command.previousTab.name"
>+            defaultHandler="org.eclipse.ui.internal.handlers.TraversePageHandler:previous">
>+      </command>
>+      <command
>             description="%command.nextSubTab.description"
>             id="org.eclipse.ui.navigate.nextSubTab"
>             categoryId="org.eclipse.ui.category.navigate"
>Index: plugin.properties
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui/plugin.properties,v
>retrieving revision 1.218
>diff -u -r1.218 plugin.properties
>--- plugin.properties	13 Apr 2009 21:50:35 -0000	1.218
>+++ plugin.properties	27 Apr 2009 09:52:34 -0000
>@@ -188,6 +188,8 @@
> command.nextPerspective.name = Next Perspective
> command.nextSubTab.name = Next Sub-Tab
> command.nextSubTab.description = Switch to the next sub-tab
>+command.nextTab.name = Next Tab
>+command.nextTab.description = Switch to the next tab
> command.nextView.description = Switch to the next view
> command.nextView.name = Next View
> command.openEditorDropDown.description = Open the editor drop down list
>@@ -209,6 +211,8 @@
> command.previousPerspective.name = Previous Perspective
> command.previousSubTab.name = Previous Sub-Tab
> command.previousSubTab.description = Switch to the previous sub-tab
>+command.previousTab.name = Previous Tab
>+command.previousTab.description = Switch to the previous tab
> command.previousView.description = Switch to the previous view
> command.previousView.name = Previous View
> command.print.description = Print

Actions: View | Diff

Attachments on bug 86248: 133332