Attachment 131544 Details for Bug 271935 – simple proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] simple proposed patch

bug_271935_patch1.txt (text/plain), 1.70 KB, created by Stephan Herrmann

on 2009-04-11 09:21:54 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Stephan Herrmann

Created: 2009-04-11 09:21:54 EDT

Size: 1.70 KB

patch

obsolete

>Index: ui/org/eclipse/jdt/ui/wizards/NewClassWizardPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/wizards/NewClassWizardPage.java,v
>retrieving revision 1.28
>diff -u -r1.28 NewClassWizardPage.java
>--- ui/org/eclipse/jdt/ui/wizards/NewClassWizardPage.java	11 Sep 2008 11:59:20 -0000	1.28
>+++ ui/org/eclipse/jdt/ui/wizards/NewClassWizardPage.java	11 Apr 2009 13:20:51 -0000
>@@ -89,7 +89,7 @@
> 		IJavaElement jelem= getInitialJavaElement(selection);
> 		initContainerPage(jelem);
> 		initTypePage(jelem);
>-		doStatusUpdate();
>+		doStatusUpdate(false);
> 
> 		boolean createMain= false;
> 		boolean createConstructors= false;
>@@ -108,9 +108,18 @@
> 	}
> 
> 	// ------ validation --------
>-	private void doStatusUpdate() {
>+	private void doStatusUpdate(boolean ignoreFirstField) {
> 		// status of all used components
>-		IStatus[] status= new IStatus[] {
>+		IStatus[] status= ignoreFirstField ?
>+				new IStatus[] {
>+				fContainerStatus,
>+				isEnclosingTypeSelected() ? fEnclosingTypeStatus : fPackageStatus,
>+				// ignore this one: fTypeNameStatus,
>+				fModifierStatus,
>+				fSuperClassStatus,
>+				fSuperInterfacesStatus
>+			}	
>+		: new IStatus[] {
> 			fContainerStatus,
> 			isEnclosingTypeSelected() ? fEnclosingTypeStatus : fPackageStatus,
> 			fTypeNameStatus,
>@@ -130,7 +139,7 @@
> 	protected void handleFieldChanged(String fieldName) {
> 		super.handleFieldChanged(fieldName);
> 
>-		doStatusUpdate();
>+		doStatusUpdate(false);
> 	}
> 
> 
>@@ -183,6 +192,7 @@
> 		super.setVisible(visible);
> 		if (visible) {
> 			setFocus();
>+			doStatusUpdate(true);
> 		} else {
> 			IDialogSettings dialogSettings= getDialogSettings();
> 			if (dialogSettings != null) {

Actions: View | Diff

Attachments on bug 271935: 131544