Attachment 130853 Details for Bug 239736 – patch for this bug.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch for this bug.

patch_for_bug_239736.patch (text/plain), 2.49 KB, created by novaeye liang

on 2009-04-03 12:16:08 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: novaeye liang

Created: 2009-04-03 12:16:08 EDT

Size: 2.49 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ve.swt
>Index: vm_swt/org/eclipse/ve/internal/jface/targetvm/WorkbenchPartHost.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.ve.swt/vm_swt/org/eclipse/ve/internal/jface/targetvm/WorkbenchPartHost.java,v
>retrieving revision 1.3
>diff -u -r1.3 WorkbenchPartHost.java
>--- vm_swt/org/eclipse/ve/internal/jface/targetvm/WorkbenchPartHost.java	14 Dec 2005 21:45:52 -0000	1.3
>+++ vm_swt/org/eclipse/ve/internal/jface/targetvm/WorkbenchPartHost.java	3 Apr 2009 15:52:28 -0000
>@@ -72,8 +72,13 @@
> 			setSimpleMethod.invoke(folder, new Object[] { Boolean.valueOf(traditionalTabs)});
> 		} catch (Exception e) {
> 		}
>-		folder.setTabPosition(tabPosition);
>-
>+		
>+		if (tabPosition != SWT.TOP && tabPosition != SWT.BOTTOM) {
>+			folder.setTabPosition(SWT.TOP);
>+		} else {
>+			folder.setTabPosition(tabPosition);
>+		}
>+		
> 		// Editor parts don't need the viewform, but viewparts will (this is where their toolbar goes).
> 		ViewForm viewForm = new ViewForm(folder, SWT.NONE);
> 		viewForm.marginHeight = 0;
>#P org.eclipse.ve.java.core
>Index: vm_vcelauncher/org/eclipse/ve/internal/java/vce/launcher/remotevm/ViewPartHost.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.ve.java.core/vm_vcelauncher/org/eclipse/ve/internal/java/vce/launcher/remotevm/ViewPartHost.java,v
>retrieving revision 1.8
>diff -u -r1.8 ViewPartHost.java
>--- vm_vcelauncher/org/eclipse/ve/internal/java/vce/launcher/remotevm/ViewPartHost.java	9 Dec 2005 21:55:57 -0000	1.8
>+++ vm_vcelauncher/org/eclipse/ve/internal/java/vce/launcher/remotevm/ViewPartHost.java	3 Apr 2009 15:52:30 -0000
>@@ -28,7 +28,8 @@
> import org.eclipse.swt.graphics.Point;
> import org.eclipse.swt.layout.FillLayout;
> import org.eclipse.swt.widgets.*;
>-import org.eclipse.ui.part.*;
>+import org.eclipse.ui.part.EditorPart;
>+import org.eclipse.ui.part.WorkbenchPart;
> 
> public class ViewPartHost {
> 
>@@ -53,7 +54,12 @@
> 	    folder.setMaximizeVisible(true);
> 	    folder.setMinimizeVisible(true);
> 
>-		folder.setTabPosition(fTabPosition);
>+	    if (fTabPosition != SWT.TOP && fTabPosition != SWT.BOTTOM) {
>+	    	folder.setTabPosition(SWT.TOP);
>+		} else {
>+			folder.setTabPosition(fTabPosition);
>+	    }
>+	    
> 		// The method CTabFolder.setSimple(boolean) is only available in 3.1 and higher so we must use reflection
> 		// to simulat the method call folder.setSimple(fTraditionalTabs);
> 		try{

Flags:

yves.yang: iplog+

Actions: View | Diff

Attachments on bug 239736: 115238 | 130852 | 130853