Attachment 129685 Details for Bug 269794 – Very basic patch that fixes the problem for me

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Very basic patch that fixes the problem for me

Hostname.patch (text/plain), 2.05 KB, created by Anders Olsson

on 2009-03-24 06:15:14 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Anders Olsson

Created: 2009-03-24 06:15:14 EDT

Size: 2.05 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jst.server.generic.core
>Index: src/org/eclipse/jst/server/generic/core/internal/ExternalLaunchConfigurationDelegate.java
>===================================================================
>RCS file: /cvsroot/webtools/servertools/plugins/org.eclipse.jst.server.generic.core/src/org/eclipse/jst/server/generic/core/internal/ExternalLaunchConfigurationDelegate.java,v
>retrieving revision 1.8
>diff -u -r1.8 ExternalLaunchConfigurationDelegate.java
>--- src/org/eclipse/jst/server/generic/core/internal/ExternalLaunchConfigurationDelegate.java	25 Aug 2006 14:37:56 -0000	1.8
>+++ src/org/eclipse/jst/server/generic/core/internal/ExternalLaunchConfigurationDelegate.java	24 Mar 2009 10:13:38 -0000
>@@ -137,17 +137,18 @@
> 		}
> 
> 		if (mode.equals("debug")) { //$NON-NLS-1$
>-			ILaunchConfigurationWorkingCopy wc = createDebuggingConfig(configuration);
>+			ILaunchConfigurationWorkingCopy wc = createDebuggingConfig(configuration, server);
> 			// if we're launching the debugging we need to wait for the config to start
> 			// before launching the debugging session
> 			serverBehavior.setDebuggingConfig(wc, mode, launch, monitor);
> 		}
> 	}
> 
>-	private ILaunchConfigurationWorkingCopy createDebuggingConfig(ILaunchConfiguration configuration) 
>+	private ILaunchConfigurationWorkingCopy createDebuggingConfig(ILaunchConfiguration configuration, IServer server) 
> 	throws CoreException {
>         ILaunchConfigurationWorkingCopy wc = configuration.getWorkingCopy();
>-        setDebugArgument(wc, IJavaLaunchConfigurationConstants.ATTR_CONNECT_MAP, "hostname", "localhost");  //$NON-NLS-1$//$NON-NLS-2$
>+        String hostname = server.getHost();
>+        setDebugArgument(wc, IJavaLaunchConfigurationConstants.ATTR_CONNECT_MAP, "hostname", hostname);  //$NON-NLS-1$//$NON-NLS-2$
>         String port = configuration.getAttribute(DEBUG_PORT, (String) null);
>         if (port==null || port.length()==0) {
>         	abort(GenericServerCoreMessages.debugPortUnspecified, null, IJavaLaunchConfigurationConstants.ERR_INTERNAL_ERROR);

Actions: View | Diff

Attachments on bug 269794: 129685