Attachment 128784 Details for Bug 268602 – Patch to fix problems

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to fix problems

GMF properties A07BZ156Q8T2R.txt (text/plain), 4.13 KB, created by Wayne

on 2009-03-13 15:54:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wayne

Created: 2009-03-13 15:54:43 EDT

Size: 4.13 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.gmf.runtime.common.ui.services.properties
>Index: src/org/eclipse/gmf/runtime/common/ui/services/properties/extended/ExtendedComboBoxCellEditor.java
>===================================================================
>RCS file: /cvsroot/modeling/org.eclipse.gmf/plugins/org.eclipse.gmf.runtime.common.ui.services.properties/src/org/eclipse/gmf/runtime/common/ui/services/properties/extended/ExtendedComboBoxCellEditor.java,v
>retrieving revision 1.3
>diff -u -r1.3 ExtendedComboBoxCellEditor.java
>--- src/org/eclipse/gmf/runtime/common/ui/services/properties/extended/ExtendedComboBoxCellEditor.java	2 Nov 2007 21:10:30 -0000	1.3
>+++ src/org/eclipse/gmf/runtime/common/ui/services/properties/extended/ExtendedComboBoxCellEditor.java	13 Mar 2009 19:45:53 -0000
>@@ -21,8 +21,6 @@
> import org.eclipse.swt.custom.CCombo;
> import org.eclipse.swt.events.KeyAdapter;
> import org.eclipse.swt.events.KeyEvent;
>-import org.eclipse.swt.events.SelectionAdapter;
>-import org.eclipse.swt.events.SelectionEvent;
> import org.eclipse.swt.events.TraverseEvent;
> import org.eclipse.swt.events.TraverseListener;
> import org.eclipse.swt.widgets.Composite;
>@@ -191,19 +189,6 @@
>             }
>         });
> 
>-        comboBox.addSelectionListener(new SelectionAdapter() {
>-
>-            public void widgetDefaultSelected(SelectionEvent event) {
>-                // called when combo box or text field selected
>-                applyEditorValueAndDeactivate();
>-            }
>-
>-            public void widgetSelected(SelectionEvent e) {
>-                // called when combo box selected
>-                widgetDefaultSelected(e);
>-            }
>-        });
>-
>          comboBox.addTraverseListener(new TraverseListener() {
> 
>             public void keyTraversed(TraverseEvent e) {
>@@ -213,6 +198,20 @@
>                 }
>             }
>         });
>+         
>+         parent.addTraverseListener(new TraverseListener() {
>+
>+             public void keyTraversed(TraverseEvent e) {
>+                 if (e.detail == SWT.TRAVERSE_ESCAPE
>+                         || e.detail == SWT.TRAVERSE_RETURN) {
>+                     e.doit = false;
>+                 }
>+                 if (e.detail == SWT.TRAVERSE_TAB_NEXT
>+                         || e.detail == SWT.TRAVERSE_TAB_PREVIOUS) {
>+                     e.doit = false;
>+                 }
>+             }
>+         });         
> 
>         if(emptyItem != null)
>         	comboBox.setText(emptyItem);
>Index: src/org/eclipse/gmf/runtime/common/ui/services/properties/extended/MultiButtonCellEditor.java
>===================================================================
>RCS file: /cvsroot/modeling/org.eclipse.gmf/plugins/org.eclipse.gmf.runtime.common.ui.services.properties/src/org/eclipse/gmf/runtime/common/ui/services/properties/extended/MultiButtonCellEditor.java,v
>retrieving revision 1.3
>diff -u -r1.3 MultiButtonCellEditor.java
>--- src/org/eclipse/gmf/runtime/common/ui/services/properties/extended/MultiButtonCellEditor.java	3 Oct 2006 15:01:54 -0000	1.3
>+++ src/org/eclipse/gmf/runtime/common/ui/services/properties/extended/MultiButtonCellEditor.java	13 Mar 2009 19:45:53 -0000
>@@ -20,6 +20,8 @@
> import org.eclipse.swt.events.KeyEvent;
> import org.eclipse.swt.events.SelectionAdapter;
> import org.eclipse.swt.events.SelectionEvent;
>+import org.eclipse.swt.events.TraverseEvent;
>+import org.eclipse.swt.events.TraverseListener;
> import org.eclipse.swt.graphics.Color;
> import org.eclipse.swt.graphics.Font;
> import org.eclipse.swt.graphics.Point;
>@@ -267,6 +269,21 @@
> 				}
> 			}
> 		});
>+		
>+        button.addTraverseListener(new TraverseListener() {
>+
>+            public void keyTraversed(TraverseEvent e) {
>+                if (e.detail == SWT.TRAVERSE_TAB_PREVIOUS) {
>+                    e.doit = false;
>+                    getControl().traverse(SWT.TRAVERSE_TAB_PREVIOUS);
>+                }
>+
>+                if (e.detail == SWT.TRAVERSE_TAB_NEXT) {
>+                    e.doit = false;
>+                    getControl().traverse(SWT.TRAVERSE_TAB_NEXT);
>+                }
>+            }
>+        });		
> 
> 		buttonList.add(button);
> 	}

Actions: View | Diff

Attachments on bug 268602: 128784 | 147456