Attachment 128075 Details for Bug 266839 – Command IDs and action factory v04

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Command IDs and action factory v04

actionFactory-v04.txt (text/plain), 6.60 KB, created by Paul Webster

on 2009-03-09 14:09:48 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Webster

Created: 2009-03-09 14:09:48 EDT

Size: 6.60 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/IWorkbenchCommandConstants.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/IWorkbenchCommandConstants.java,v
>retrieving revision 1.5
>diff -u -r1.5 IWorkbenchCommandConstants.java
>--- Eclipse UI/org/eclipse/ui/IWorkbenchCommandConstants.java	9 Mar 2009 16:54:55 -0000	1.5
>+++ Eclipse UI/org/eclipse/ui/IWorkbenchCommandConstants.java	9 Mar 2009 18:09:05 -0000
>@@ -275,30 +275,41 @@
>      */
>     public static final String NAVIGATE_SHOWIN = "org.eclipse.ui.navigate.showIn"; //$NON-NLS-1$
> 
>+    /**
>+     * Id for command "Show In" in category "Navigate"
>+     * (value is <code>"org.eclipse.ui.navigate.showInQuickMenu"</code>).
>+     */
>+    public static final String NAVIGATE_SHOWINQUICKMENU = "org.eclipse.ui.navigate.showInQuickMenu"; //$NON-NLS-1$
>+
>     // project category
>     
>     /**
>      * Id for command "Build All" in category "Project".
>+     * (value is <code>"org.eclipse.ui.project.buildAll"</code>).
>      */
>     public static final String PROJECT_BUILDALL = "org.eclipse.ui.project.buildAll"; //$NON-NLS-1$
> 
>     /**
>      * Id for command "Build Project" in category "Project".
>+     * (value is <code>"org.eclipse.ui.project.buildProject"</code>).
>      */
>     public static final String PROJECT_BUILDPROJECT = "org.eclipse.ui.project.buildProject"; //$NON-NLS-1$
> 
>     /**
>      * Id for command "Close Project" in category "Project".
>+     * (value is <code>"org.eclipse.ui.project.closeProject"</code>).
>      */
>     public static final String PROJECT_CLOSEPROJECT = "org.eclipse.ui.project.closeProject"; //$NON-NLS-1$
> 
>     /**
>      * Id for command "Close Unrelated Projects" in category "Project".
>+     * (value is <code>"org.eclipse.ui.project.closeUnrelatedProjects"</code>).
>      */
>     public static final String PROJECT_CLOSEUNRELATEDPROJECTS = "org.eclipse.ui.project.closeUnrelatedProjects"; //$NON-NLS-1$
> 
>     /**
>      * Id for command "Open Project" in category "Project".
>+     * (value is <code>"org.eclipse.ui.project.openProject"</code>).
>      */
>     public static final String PROJECT_OPENPROJECT = "org.eclipse.ui.project.openProject"; //$NON-NLS-1$
> 
>@@ -317,6 +328,12 @@
>     public static final String WINDOW_NEWEDITOR = "org.eclipse.ui.window.newEditor"; //$NON-NLS-1$
> 
>     /**
>+     * Id for command "Show View Menu" in category "Window"
>+     * (value is <code>"org.eclipse.ui.window.showViewMenu"</code>).
>+     */
>+    public static final String WINDOW_SHOWVIEWMENU = "org.eclipse.ui.window.showViewMenu"; //$NON-NLS-1$
>+
>+    /**
>      * Id for command "Activate Editor" in category "Window"
>      * (value is <code>"org.eclipse.ui.window.activateEditor"</code>).
>      */
>Index: Eclipse UI/org/eclipse/ui/actions/ActionFactory.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/actions/ActionFactory.java,v
>retrieving revision 1.73
>diff -u -r1.73 ActionFactory.java
>--- Eclipse UI/org/eclipse/ui/actions/ActionFactory.java	9 Mar 2009 16:36:53 -0000	1.73
>+++ Eclipse UI/org/eclipse/ui/actions/ActionFactory.java	9 Mar 2009 18:09:05 -0000
>@@ -1503,7 +1503,7 @@
>      * maintains its enablement state.
>      */
>     public static final ActionFactory SHOW_VIEW_MENU = new ActionFactory(
>-            "showViewMenu") {//$NON-NLS-1$
>+            "showViewMenu", IWorkbenchCommandConstants.WINDOW_SHOWVIEWMENU) {//$NON-NLS-1$
>         
>         /* (non-Javadoc)
>          * @see org.eclipse.ui.actions.ActionFactory#create(org.eclipse.ui.IWorkbenchWindow)
>@@ -1512,7 +1512,8 @@
>             if (window == null) {
>                 throw new IllegalArgumentException();
>             }
>-            WorkbenchCommandAction action=new WorkbenchCommandAction("org.eclipse.ui.window.showViewMenu",window); //$NON-NLS-1$
>+			WorkbenchCommandAction action = new WorkbenchCommandAction(
>+					getCommandId(), window);
>             action.setId(getId());
>             action.setText(WorkbenchMessages.ShowViewMenuAction_text);
>             action.setToolTipText(WorkbenchMessages.ShowViewMenuAction_toolTip);
>#P org.eclipse.ui.ide
>Index: src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java,v
>retrieving revision 1.116
>diff -u -r1.116 WorkbenchActionBuilder.java
>--- src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java	15 Dec 2008 13:03:20 -0000	1.116
>+++ src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java	9 Mar 2009 18:09:06 -0000
>@@ -40,6 +40,7 @@
> import org.eclipse.ui.IPageListener;
> import org.eclipse.ui.ISharedImages;
> import org.eclipse.ui.IWorkbenchActionConstants;
>+import org.eclipse.ui.IWorkbenchCommandConstants;
> import org.eclipse.ui.IWorkbenchPage;
> import org.eclipse.ui.IWorkbenchWindow;
> import org.eclipse.ui.actions.ActionFactory;
>@@ -1128,7 +1129,7 @@
>             register(introAction);
>         }
> 
>-        String showInQuickMenuId = "org.eclipse.ui.navigate.showInQuickMenu"; //$NON-NLS-1$
>+        String showInQuickMenuId = IWorkbenchCommandConstants.NAVIGATE_SHOWINQUICKMENU;
>         showInQuickMenu = new QuickMenuAction(showInQuickMenuId) {
>             protected void fillMenu(IMenuManager menu) {
>                 menu.add(ContributionItemFactory.VIEWS_SHOW_IN
>Index: src/org/eclipse/ui/views/markers/internal/MarkerView.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerView.java,v
>retrieving revision 1.118
>diff -u -r1.118 MarkerView.java
>--- src/org/eclipse/ui/views/markers/internal/MarkerView.java	24 Mar 2008 19:13:34 -0000	1.118
>+++ src/org/eclipse/ui/views/markers/internal/MarkerView.java	9 Mar 2009 18:09:07 -0000
>@@ -80,6 +80,7 @@
> import org.eclipse.ui.ISelectionListener;
> import org.eclipse.ui.IViewSite;
> import org.eclipse.ui.IWorkbenchActionConstants;
>+import org.eclipse.ui.IWorkbenchCommandConstants;
> import org.eclipse.ui.IWorkbenchPart;
> import org.eclipse.ui.PartInitException;
> import org.eclipse.ui.PlatformUI;
>@@ -1598,7 +1599,7 @@
> 				.getWorkbench().getAdapter(IBindingService.class);
> 		if (bindingService != null) {
> 			String keyBinding = bindingService
>-					.getBestActiveBindingFormattedFor("org.eclipse.ui.navigate.showInQuickMenu"); //$NON-NLS-1$
>+					.getBestActiveBindingFormattedFor(IWorkbenchCommandConstants.NAVIGATE_SHOWINQUICKMENU);
> 			if (keyBinding != null) {
> 				showInLabel += '\t' + keyBinding;
> 			}

Actions: View | Diff

Attachments on bug 266839: 128037 | 128052 | 128054 | 128075