Attachment 126175 Details for Bug 184684 – Patch to correct the dialog's behaviour.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to correct the dialog's behaviour.

bug184684-patch-v1.txt (text/plain), 3.83 KB, created by Remy Suen

on 2009-02-19 11:22:26 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Remy Suen

Created: 2009-02-19 11:22:26 EST

Size: 3.83 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.team.cvs.ui
>Index: src/org/eclipse/team/internal/ccvs/ui/wizards/CheckoutAsLocationSelectionPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/wizards/CheckoutAsLocationSelectionPage.java,v
>retrieving revision 1.17
>diff -u -r1.17 CheckoutAsLocationSelectionPage.java
>--- src/org/eclipse/team/internal/ccvs/ui/wizards/CheckoutAsLocationSelectionPage.java	10 May 2006 17:48:31 -0000	1.17
>+++ src/org/eclipse/team/internal/ccvs/ui/wizards/CheckoutAsLocationSelectionPage.java	19 Feb 2009 16:21:52 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2006 IBM Corporation and others.
>+ * Copyright (c) 2000, 2009 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -155,7 +155,7 @@
> 	private Composite createUserSpecifiedProjectLocationGroup(Composite parent, boolean enabled) {
> 	
> 		// This group needs 3 columns
>-		Composite projectGroup = createComposite(parent, 3, false);
>+		Composite projectGroup = createComposite(parent, 3, true, false);
> 		
> 		// location label
> 		locationLabel = new Label(projectGroup, SWT.NONE);
>Index: src/org/eclipse/team/internal/ccvs/ui/wizards/CVSWizardPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/ui/wizards/CVSWizardPage.java,v
>retrieving revision 1.23
>diff -u -r1.23 CVSWizardPage.java
>--- src/org/eclipse/team/internal/ccvs/ui/wizards/CVSWizardPage.java	10 May 2006 17:48:27 -0000	1.23
>+++ src/org/eclipse/team/internal/ccvs/ui/wizards/CVSWizardPage.java	19 Feb 2009 16:21:52 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2006 IBM Corporation and others.
>+ * Copyright (c) 2000, 2009 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -105,14 +105,27 @@
> 	 * Creates composite control and sets the default layout data.
> 	 * @param parent  the parent of the new composite
> 	 * @param numColumns  the number of columns for the new composite
>-	 * @param grabExcess TODO
>+	 * @param grabExcess <code>true</code> if the composite should take up the remaining horizontal and vertical space
> 	 *
> 	 * @return the newly-created coposite
> 	 */
> 	protected Composite createComposite(Composite parent, int numColumns, boolean grabExcess) {
>+		return createComposite(parent, numColumns, grabExcess, grabExcess);
>+	}
>+	
>+	/**
>+	 * Creates composite control and sets the default layout data.
>+	 * @param parent  the parent of the new composite
>+	 * @param numColumns  the number of columns for the new composite
>+	 * @param grabExcessHorizontalSpace <code>true</code> if the composite should take up the remaining horizontal space
>+	 * @param grabExcessVerticalSpace <code>true</code> if the composite should take up the remaining vertical space
>+	 *
>+	 * @return the newly-created coposite
>+	 */
>+	protected Composite createComposite(Composite parent, int numColumns, boolean grabExcessHorizontalSpace, boolean grabExcessVerticalSpace) {
> 		final Composite composite = new Composite(parent, SWT.NULL);
> 		composite.setLayout(new GridLayout(numColumns, false));
>-		composite.setLayoutData(new GridData(SWT.FILL, SWT.FILL, grabExcess, grabExcess));
>+		composite.setLayoutData(new GridData(SWT.FILL, SWT.FILL, grabExcessHorizontalSpace, grabExcessHorizontalSpace));
> 		return composite;
> 	}
>

Actions: View | Diff

Attachments on bug 184684: 65375 | 126175 | 142006 | 142007