Attachment 12494 Details for Bug 66297 – Patch to KeysPreferencePage

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to KeysPreferencePage

Bug66297-KeysPreferencePage.patch (text/plain), 2.10 KB, created by Douglas Pollock

on 2004-06-18 12:17:09 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Douglas Pollock

Created: 2004-06-18 12:17:09 EDT

Size: 2.10 KB

patch

obsolete

>Index: KeysPreferencePage.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/commands/KeysPreferencePage.java,v
>retrieving revision 1.94
>diff -u -r1.94 KeysPreferencePage.java
>--- KeysPreferencePage.java	20 May 2004 15:16:03 -0000	1.94
>+++ KeysPreferencePage.java	18 Jun 2004 16:10:58 -0000
>@@ -759,20 +759,6 @@
>             }
>         });
> 
>-        // Arrow buttons aren't normally added to the tab list. Let's fix that.
>-        Control[] tabStops = groupKeySequence.getTabList();
>-        ArrayList newTabStops = new ArrayList();
>-        for (int i = 0; i < tabStops.length; i++) {
>-            Control tabStop = tabStops[i];
>-            newTabStops.add(tabStop);
>-            if (textKeySequence.equals(tabStop)) {
>-                newTabStops.add(buttonAddKey);
>-            }
>-        }
>-        Control[] newTabStopArray = (Control[]) newTabStops
>-                .toArray(new Control[newTabStops.size()]);
>-        groupKeySequence.setTabList(newTabStopArray);
>-
>         // Construct the menu to attach to the above button.
>         menuButtonAddKey = new Menu(buttonAddKey);
>         Iterator trappedKeyItr = KeySequenceText.TRAPPED_KEYS.iterator();
>@@ -839,6 +825,20 @@
>                         selectedTableAssignmentsForKeySequence();
>                     }
>                 });
>+
>+        // Arrow buttons aren't normally added to the tab list. Let's fix that.
>+        Control[] tabStops = groupKeySequence.getTabList();
>+        ArrayList newTabStops = new ArrayList();
>+        for (int i = 0; i < tabStops.length; i++) {
>+            Control tabStop = tabStops[i];
>+            newTabStops.add(tabStop);
>+            if (textKeySequence.equals(tabStop)) {
>+                newTabStops.add(buttonAddKey);
>+            }
>+        }
>+        Control[] newTabStopArray = (Control[]) newTabStops
>+                .toArray(new Control[newTabStops.size()]);
>+        groupKeySequence.setTabList(newTabStopArray);
> 
>         Composite compositeContext = new Composite(composite, SWT.NULL);
>         gridLayout = new GridLayout();

Actions: View | Diff

Attachments on bug 66297: 12494