Attachment 124783 Details for Bug 263751 – Suggested patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Suggested patch

clipboard.txt (text/plain), 1.29 KB, created by Francis Upton IV

on 2009-02-05 03:03:48 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Francis Upton IV

Created: 2009-02-05 03:03:48 EST

Size: 1.29 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.ui
>Index: ui/org/eclipse/jdt/internal/ui/navigator/JavaDropAdapterAssistant.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/navigator/JavaDropAdapterAssistant.java,v
>retrieving revision 1.9
>diff -u -r1.9 JavaDropAdapterAssistant.java
>--- ui/org/eclipse/jdt/internal/ui/navigator/JavaDropAdapterAssistant.java	4 Feb 2009 11:31:15 -0000	1.9
>+++ ui/org/eclipse/jdt/internal/ui/navigator/JavaDropAdapterAssistant.java	5 Feb 2009 08:02:54 -0000
>@@ -68,6 +68,7 @@
> 				switch (dropAdapter.getCurrentOperation()) {
> 					case DND.DROP_MOVE :
> 						handleDropMove(target);
>+						dropTargetEvent.detail = DND.DROP_NONE;
> 						break;
> 					case DND.DROP_COPY :
> 						handleDropCopy(target);
>@@ -79,11 +80,6 @@
> 				ExceptionHandler.handle(e, RefactoringMessages.OpenRefactoringWizardAction_refactoring, RefactoringMessages.OpenRefactoringWizardAction_exception);
> 			} catch (InterruptedException e) {
> 				//ok
>-			} finally {
>-				// The drag source listener must not perform any operation
>-				// since this drop adapter did the remove of the source even
>-				// if we moved something.
>-				//event.detail= DND.DROP_NONE;
> 			}
> 			clear();
> 			return Status.OK_STATUS;

Flags:

daniel_megert: review+

Actions: View | Diff

Attachments on bug 263751: 124783