Attachment 124683 Details for Bug 239499 – I just noticed that the Logic Example has a ColorConstants file. I've changed the wire code, so it grabs its colors from LogicColorConstants instead of using magic numbers

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] I just noticed that the Logic Example has a ColorConstants file. I've changed the wire code, so it grabs its colors from LogicColorConstants instead of using magic numbers

patch239499.txt (text/plain), 2.54 KB, created by Brendan Curran-Johnson

on 2009-02-04 10:16:35 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Curran-Johnson

Created: 2009-02-04 10:16:35 EST

Size: 2.54 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.gef.examples.logic
>Index: src/org/eclipse/gef/examples/logicdesigner/edit/WireEditPart.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.gef/examples/org.eclipse.gef.examples.logic/src/org/eclipse/gef/examples/logicdesigner/edit/WireEditPart.java,v
>retrieving revision 1.9
>diff -u -r1.9 WireEditPart.java
>--- src/org/eclipse/gef/examples/logicdesigner/edit/WireEditPart.java	14 Feb 2006 20:26:53 -0000	1.9
>+++ src/org/eclipse/gef/examples/logicdesigner/edit/WireEditPart.java	4 Feb 2009 15:09:56 -0000
>@@ -31,6 +31,7 @@
> 
> import org.eclipse.gef.examples.logicdesigner.LogicMessages;
> import org.eclipse.gef.examples.logicdesigner.figures.FigureFactory;
>+import org.eclipse.gef.examples.logicdesigner.figures.LogicColorConstants;
> import org.eclipse.gef.examples.logicdesigner.model.Wire;
> import org.eclipse.gef.examples.logicdesigner.model.WireBendpoint;
> 
>@@ -46,10 +47,6 @@
> 
> AccessibleEditPart acc;
> 
>-public static final Color
>-	alive = new Color(Display.getDefault(),0,74,168),
>-	dead  = new Color(Display.getDefault(),0,0,0);
>-
> public void activate(){
> 	super.activate();
> 	getWire().addPropertyChangeListener(this);
>@@ -175,9 +172,9 @@
> protected void refreshVisuals() {
> 	refreshBendpoints();
> 	if (getWire().getValue())
>-		getWireFigure().setForegroundColor(alive);
>+		getWireFigure().setForegroundColor(LogicColorConstants.wireAlive);
> 	else
>-		getWireFigure().setForegroundColor(dead);
>+		getWireFigure().setForegroundColor(LogicColorConstants.wireDead);
> }
> 
> }
>Index: src/org/eclipse/gef/examples/logicdesigner/figures/LogicColorConstants.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.gef/examples/org.eclipse.gef.examples.logic/src/org/eclipse/gef/examples/logicdesigner/figures/LogicColorConstants.java,v
>retrieving revision 1.6
>diff -u -r1.6 LogicColorConstants.java
>--- src/org/eclipse/gef/examples/logicdesigner/figures/LogicColorConstants.java	30 Mar 2005 21:26:50 -0000	1.6
>+++ src/org/eclipse/gef/examples/logicdesigner/figures/LogicColorConstants.java	4 Feb 2009 15:09:56 -0000
>@@ -23,5 +23,7 @@
> public final static Color connectorGreen = new Color(null,0,69,40);
> public final static Color logicBackgroundBlue = new Color(null, 200, 200, 240);
> public final static Color ghostFillColor = new Color(null, 31, 31, 31);
>+public final static Color wireAlive = new Color(null,0,190,0);
>+public final static Color wireDead = new Color(null,0,0,0);
> 
> }

Actions: View | Diff

Attachments on bug 239499: 123591 | 123599 | 123794 | 123795 | 124683