Attachment 124104 Details for Bug 262840 – Proposed fix.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed fix.

20090128_262840.patch (text/plain), 1.77 KB, created by Pawel Piech

on 2009-01-28 17:44:25 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Pawel Piech

Created: 2009-01-28 17:44:25 EST

Size: 1.77 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.debug.ui
>Index: ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationPresentationManager.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationPresentationManager.java,v
>retrieving revision 1.46
>diff -u -r1.46 LaunchConfigurationPresentationManager.java
>--- ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationPresentationManager.java	10 Jul 2007 19:31:14 -0000	1.46
>+++ ui/org/eclipse/debug/internal/ui/launchConfigurations/LaunchConfigurationPresentationManager.java	28 Jan 2009 22:30:33 -0000
>@@ -238,21 +238,18 @@
> 					delegate = config.getType().getPreferredDelegate(modes);
> 				}
> 				Set delegateSet = tabs[i].getDelegateSet();
>+				if (delegate == null) {
>+                    ILaunchDelegate[] delegates = config.getType().getDelegates(modes);
>+                    if (delegates.length == 1) {
>+                        delegate = delegates[0];
>+                    }
>+				}
>+				
> 				if(delegate != null) {
> 					if(delegateSet.isEmpty() || delegateSet.contains(delegate.getId())) {
> 						set.add(tabs[i]);
> 					}
> 				}
>-				else {
>-					//otherwise filter based on the collection of delegates for the modes
>-					ILaunchDelegate[] delegates = config.getType().getDelegates(modes);
>-					for(int j = 0; j < delegates.length; j++) {
>-						if(delegateSet.size() == 0 || delegateSet.contains(delegates[j].getId())) {
>-							//associated with all modes and tab groups or only specific ones if indicated
>-							set.add(tabs[i]);
>-						}
>-					}
>-				}
> 			}
> 		}
> 		return (LaunchConfigurationTabExtension[]) set.toArray(new LaunchConfigurationTabExtension[set.size()]);

Actions: View | Diff

Attachments on bug 262840: 124101 | 124104 | 124478