Attachment 12383 Details for Bug 67046 – Minimal patch that moves the call to super() between un-/configure()

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Minimal patch that moves the call to super() between un-/configure()

(text/plain), 1.12 KB, created by Christof Marti

on 2004-06-17 09:39:40 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Christof Marti

Created: 2004-06-17 09:39:40 EDT

Size: 1.12 KB

patch

obsolete

>Index: JavaEditor.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/JavaEditor.java,v
>retrieving revision 1.297
>diff -u -r1.297 JavaEditor.java
>--- JavaEditor.java	9 Jun 2004 19:27:52 -0000	1.297
>+++ JavaEditor.java	17 Jun 2004 13:32:17 -0000
>@@ -2705,6 +2753,7 @@
> 		ISourceViewer sourceViewer= getSourceViewer();
> 		if (!(sourceViewer instanceof ISourceViewerExtension2)) {
> 			setPreferenceStore(createCombinedPreferenceStore(input));
>+			super.doSetInput(input);
> 			internalDoSetInput(input);
> 			return;
> 		}
>@@ -2716,6 +2765,7 @@
> 		((ISourceViewerExtension2)sourceViewer).unconfigure();
> 		
> 		setPreferenceStore(createCombinedPreferenceStore(input));
>+		super.doSetInput(input);
> 		
> 		// install & register preference store listener 
> 		sourceViewer.configure(getSourceViewerConfiguration());
>@@ -2727,7 +2777,6 @@
> 	}
> 	
> 	private void internalDoSetInput(IEditorInput input) throws CoreException {
>-		super.doSetInput(input);
> 		
> 		if (fEncodingSupport != null)
> 			fEncodingSupport.reset();

Actions: View | Diff

Attachments on bug 67046: 12383 | 12385 | 12386 | 12740