Attachment 120169 Details for Bug 248623 – almost working proposal

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] almost working proposal

248623.txt (text/plain), 2.60 KB, created by Dimitar Giormov

on 2008-12-11 04:54:31 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitar Giormov

Created: 2008-12-11 04:54:31 EST

Size: 2.60 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jst.j2ee.ui
>Index: j2ee_ui/org/eclipse/jst/j2ee/internal/AvailableJ2EEComponentsForEARContentProvider.java
>===================================================================
>RCS file: /cvsroot/webtools/jeetools/plugins/org.eclipse.jst.j2ee.ui/j2ee_ui/org/eclipse/jst/j2ee/internal/AvailableJ2EEComponentsForEARContentProvider.java,v
>retrieving revision 1.19
>diff -u -r1.19 AvailableJ2EEComponentsForEARContentProvider.java
>--- j2ee_ui/org/eclipse/jst/j2ee/internal/AvailableJ2EEComponentsForEARContentProvider.java	19 Nov 2008 14:17:42 -0000	1.19
>+++ j2ee_ui/org/eclipse/jst/j2ee/internal/AvailableJ2EEComponentsForEARContentProvider.java	11 Dec 2008 09:53:30 -0000
>@@ -22,6 +22,7 @@
> import org.eclipse.core.runtime.CoreException;
> import org.eclipse.core.runtime.IPath;
> import org.eclipse.jem.util.logger.proxy.Logger;
>+import org.eclipse.jface.viewers.ILabelProvider;
> import org.eclipse.jface.viewers.ILabelProviderListener;
> import org.eclipse.jface.viewers.IStructuredContentProvider;
> import org.eclipse.jface.viewers.ITableLabelProvider;
>@@ -37,6 +38,7 @@
> import org.eclipse.jst.j2ee.model.ModelProviderManager;
> import org.eclipse.jst.javaee.application.Application;
> import org.eclipse.swt.graphics.Image;
>+import org.eclipse.ui.model.WorkbenchLabelProvider;
> import org.eclipse.wst.common.componentcore.ComponentCore;
> import org.eclipse.wst.common.componentcore.ModuleCoreNature;
> import org.eclipse.wst.common.componentcore.internal.resources.VirtualArchiveComponent;
>@@ -51,6 +53,8 @@
> 	private IVirtualComponent earComponent;
> 	private boolean isEE5 = false;
> 	private String libDir = null;
>+
>+	private ILabelProvider decoratingWorkbenchLabelProvider = WorkbenchLabelProvider.getDecoratingWorkbenchLabelProvider();
> 	
> 	
> 	public AvailableJ2EEComponentsForEARContentProvider(IVirtualComponent aEarComponent, int j2eeVersion) {
>@@ -212,6 +216,15 @@
> 	 * @see org.eclipse.jface.viewers.ITableLabelProvider#getColumnImage(java.lang.Object, int)
> 	 */
> 	public Image getColumnImage(Object element, int columnIndex) {
>+		if (columnIndex >=2){
>+			return null;
>+		}
>+		if (element instanceof IVirtualComponent) {
>+			IVirtualComponent comp = (IVirtualComponent)element;
>+			return decoratingWorkbenchLabelProvider.getImage(comp.getProject());
>+		} else if (element instanceof IProject){
>+			return decoratingWorkbenchLabelProvider.getImage(element);
>+		}
> 		return null;
> 	}
> 
>@@ -293,5 +306,8 @@
> 	 * @see org.eclipse.jface.viewers.IContentProvider#dispose()
> 	 */
> 	public void dispose() {
>+		if (decoratingWorkbenchLabelProvider != null) {
>+			decoratingWorkbenchLabelProvider.dispose();
>+		}
> 	}
> }

Actions: View | Diff

Attachments on bug 248623: 120169 | 131379 | 131633