Attachment 119884 Details for Bug 257022 – The same patch without the modifications to qx.js and qx-debug.js

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] The same patch without the modifications to qx.js and qx-debug.js

qx_0.7.4_rap_patch.txt (text/plain), 14.76 KB, created by Ralf Sternberg

on 2008-12-09 05:34:00 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Sternberg

Created: 2008-12-09 05:34:00 EST

Size: 14.76 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Table.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Table.js,v
>retrieving revision 1.17
>diff -u -r1.17 Table.js
>--- js/org/eclipse/swt/widgets/Table.js	26 Nov 2008 14:48:07 -0000	1.17
>+++ js/org/eclipse/swt/widgets/Table.js	1 Dec 2008 08:51:39 -0000
>@@ -157,23 +157,27 @@
>     var req = org.eclipse.swt.Request.getInstance();
>     if( this._horzScrollBar ) {
>       this._horzScrollBar.removeEventListener( "changeValue", this._onHorzScrollBarChangeValue, this );
>-      this._horzScrollBar.dispose();
>+//      this._horzScrollBar.dispose();
>+      this._horzScrollBar.destroy();
>       this._horzScrollBar = null;
>     }
>     if( this._vertScrollBar ) {
>       this._vertScrollBar.removeEventListener( "changeValue", this._onVertScrollBarChangeValue, this );
>-      this._vertScrollBar.dispose();
>+//      this._vertScrollBar.dispose();
>+      this._vertScrollBar.destroy();
>       this._vertScrollBar = null;
>     }
>     if( this._clientArea ) {
>       this._clientArea.removeEventListener( "mousewheel", this._onClientAreaMouseWheel, this );
>       this._clientArea.removeEventListener( "appear", this._onClientAppear, this );
>-      this._clientArea.dispose();
>+//      this._clientArea.dispose();
>+      this._clientArea.destroy();
>       org.eclipse.swt.WidgetManager.getInstance().remove( this._clientArea );
>       this._clientArea = null;
>     }
>     if( this._columnArea ) {
>-      this._columnArea.dispose();
>+//      this._columnArea.dispose();
>+      this._columnArea.destroy();
>       this._columnArea = null;
>     }
>     if( this._resizeLine ) {
>@@ -188,7 +192,8 @@
>     }
>     if( this._checkBoxes !== null ) {
>       for( var i = 0; i < this._checkBoxes.length; i++ ) {
>-        this._checkBoxes[ i ].dispose();
>+//        this._checkBoxes[ i ].dispose();
>+        this._checkBoxes[ i ].destroy();
>       }
>       this._checkBoxes = null;
>     }
>@@ -919,7 +924,8 @@
>               var checkBox = this._checkBoxes.shift();
>               checkBox.removeEventListener( "changeChecked", this._onCheckBoxClick, this );
>               checkBox.setParent( null );
>-              checkBox.dispose();
>+//              checkBox.dispose();
>+              checkBox.destroy();
>             }
>             var row = this._rows.shift();
>             this._unhookRowEventListener( row );
>Index: js/org/eclipse/swt/widgets/Tree.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Tree.js,v
>retrieving revision 1.7
>diff -u -r1.7 Tree.js
>--- js/org/eclipse/swt/widgets/Tree.js	19 Aug 2008 15:40:24 -0000	1.7
>+++ js/org/eclipse/swt/widgets/Tree.js	1 Dec 2008 08:51:40 -0000
>@@ -83,7 +83,8 @@
>     this.removeEventListener( "changeHeight", this._onChangeSize, this );
> 
>     if( this._columnArea ) {
>-      this._columnArea.dispose();
>+//      this._columnArea.dispose();
>+      this._columnArea.destroy();
>       this._columnArea = null;
>     }
>     if( this._tree ) { 
>@@ -108,7 +109,8 @@
>       this._tree.removeEventListener( "blur", this._onFocusOut, this );
>       this._tree.removeEventListener( "appear", this._updateLayout, this );
>       this._tree.removeEventListener( "changeElement", this._onTreeElementChange, this._tree );
>-      this._tree.dispose();
>+//      this._tree.dispose();
>+      this._tree.destroy();
>       this._tree = null;
>     }
>   },
>Index: js/org/eclipse/swt/widgets/Separator.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Separator.js,v
>retrieving revision 1.2
>diff -u -r1.2 Separator.js
>--- js/org/eclipse/swt/widgets/Separator.js	12 Jun 2008 13:14:28 -0000	1.2
>+++ js/org/eclipse/swt/widgets/Separator.js	1 Dec 2008 08:51:38 -0000
>@@ -44,7 +44,8 @@
>   },
>   
>   destruct : function() {
>-    this._disposeObjects( "_line" );
>+//    this._disposeObjects( "_line" );
>+    this._line.destroy();
>   },
>   
>   members : {
>Index: js/org/eclipse/swt/widgets/TableColumn.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/TableColumn.js,v
>retrieving revision 1.4
>diff -u -r1.4 TableColumn.js
>--- js/org/eclipse/swt/widgets/TableColumn.js	15 Oct 2008 09:44:05 -0000	1.4
>+++ js/org/eclipse/swt/widgets/TableColumn.js	1 Dec 2008 08:51:39 -0000
>@@ -68,7 +68,8 @@
>     this.removeEventListener( "mouseout", this._onMouseOut, this );
>     this.removeEventListener( "mousedown", this._onMouseDown, this );
>     this.removeEventListener( "mouseup", this._onMouseUp, this );
>-    this._disposeFields( "_sortImage" );
>+//    this._disposeFields( "_sortImage" );
>+    this._sortImage.destroy();
>     if( !this._table.getDisposed() ) {
>       this._table._removeColumn( this );
>     }
>Index: js/org/eclipse/swt/widgets/DateTimeCalendar.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/DateTimeCalendar.js,v
>retrieving revision 1.4
>diff -u -r1.4 DateTimeCalendar.js
>--- js/org/eclipse/swt/widgets/DateTimeCalendar.js	18 Sep 2008 10:53:27 -0000	1.4
>+++ js/org/eclipse/swt/widgets/DateTimeCalendar.js	1 Dec 2008 08:51:38 -0000
>@@ -35,7 +35,8 @@
>   destruct : function() {
>     this._calendar.removeEventListener( "changeDate", this._onChangeDate, this );
>     this.removeEventListener( "contextmenu", this._onContextMenu, this );
>-    this._disposeObjects( "_calendar" );
>+    //this._disposeObjects( "_calendar" );
>+    this._calendar.destroy();
>   },
> 
>   members : {
>Index: js/org/eclipse/swt/widgets/CoolItem.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/CoolItem.js,v
>retrieving revision 1.3
>diff -u -r1.3 CoolItem.js
>--- js/org/eclipse/swt/widgets/CoolItem.js	12 Jun 2008 13:14:28 -0000	1.3
>+++ js/org/eclipse/swt/widgets/CoolItem.js	1 Dec 2008 08:51:38 -0000
>@@ -37,7 +37,8 @@
>       this._handle.removeEventListener( "mousedown", this._onHandleMouseDown, this );
>       this._handle.removeEventListener( "mousemove", this._onHandleMouseMove, this );
>       this._handle.removeEventListener( "mouseup", this._onHandleMouseUp, this );
>-      this._handle.dispose();
>+      //this._handle.dispose();
>+      this._handle.destroy();
>     }
>   },
> 
>Index: js/org/eclipse/swt/widgets/Scale.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Scale.js,v
>retrieving revision 1.3
>diff -u -r1.3 Scale.js
>--- js/org/eclipse/swt/widgets/Scale.js	19 Nov 2008 18:29:01 -0000	1.3
>+++ js/org/eclipse/swt/widgets/Scale.js	1 Dec 2008 08:51:38 -0000
>@@ -106,14 +106,19 @@
>     this.removeEventListener( "contextmenu", this._onContextMenu, this );
>     this.removeEventListener( "keypress", this._onKeyPress, this );
>     this.removeEventListener( "mousewheel", this._onMouseWheel, this );
>-    this._disposeObjects( "_line",
>-                          "_thumb",
>-                          "_minMarker",
>-                          "_maxMarker" );
>+//    this._disposeObjects( "_line",
>+//                          "_thumb",
>+//                          "_minMarker",
>+//                          "_maxMarker" );
>+    this._line.destroy();
>+    this._thumb.destroy();
>+    this._minMarker.destroy();
>+    this._maxMarker.destroy();
>     // Clear and dispose markers
>     for( var i = 0; i < this._middleMarkers.length; i++ ) {
>       var marker = this._middleMarkers[ i ];      
>-      marker.dispose();
>+//      marker.dispose();
>+      marker.destroy();
>     }                      
>   },  
> 
>@@ -332,7 +337,8 @@
>       for( var i = 0; i < this._middleMarkers.length; i++ ) {
>         var marker = this._middleMarkers[ i ];
>         this.remove( marker );
>-        marker.dispose();
>+//        marker.dispose();
>+        marker.destroy();
>       }
>       
>       // Create and add new markets
>Index: js/org/eclipse/swt/widgets/Sash.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Sash.js,v
>retrieving revision 1.2
>diff -u -r1.2 Sash.js
>--- js/org/eclipse/swt/widgets/Sash.js	12 Jun 2008 13:14:28 -0000	1.2
>+++ js/org/eclipse/swt/widgets/Sash.js	1 Dec 2008 08:51:38 -0000
>@@ -30,7 +30,8 @@
> 
>   destruct : function() {
>     this._removeStyle( this.getOrientation() );
>-    this._disposeObjects( "_slider" );
>+//    this._disposeObjects( "_slider" );
>+    this._slider.destroy();
>   },
> 
>   properties : {
>Index: js/org/eclipse/swt/widgets/TreeItem.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/TreeItem.js,v
>retrieving revision 1.3
>diff -u -r1.3 TreeItem.js
>--- js/org/eclipse/swt/widgets/TreeItem.js	8 Jul 2008 15:59:09 -0000	1.3
>+++ js/org/eclipse/swt/widgets/TreeItem.js	1 Dec 2008 08:51:40 -0000
>@@ -71,7 +71,8 @@
>     if( this._checkBox != null ) {
>       this._checkBox.removeEventListener( "click", this._onChangeChecked, this );
>       this._checkBox.removeEventListener( "dblclick", this._onCheckBoxDblClick, this );
>-      this._checkBox.dispose();
>+//      this._checkBox.dispose();
>+      this._checkBox.destroy();
>     }
>     this.removeEventListener( "click", this._onClick, this );
>     this.removeEventListener( "dblclick", this._onDblClick, this );
>Index: js/org/eclipse/swt/widgets/ExpandItem.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/ExpandItem.js,v
>retrieving revision 1.2
>diff -u -r1.2 ExpandItem.js
>--- js/org/eclipse/swt/widgets/ExpandItem.js	18 Sep 2008 10:53:27 -0000	1.2
>+++ js/org/eclipse/swt/widgets/ExpandItem.js	1 Dec 2008 08:51:38 -0000
>@@ -62,7 +62,10 @@
>     this._chevron.removeEventListener( "mouseover", this._onHandleMouseOver, this );
>     this._chevron.removeEventListener( "mouseout", this._onHandleMouseOut, this ); 
>     this._chevron.removeEventListener( "contextmenu", this._onContextMenu, this );   
>-    this._disposeObjects( "_header", "_chevron", "_frameBorder" );     
>+//    this._disposeObjects( "_header", "_chevron", "_frameBorder" );
>+    this._disposeObjects( "_frameBorder" );
>+    this._header.destroy();
>+    this._chevron.destroy();
>   },
> 
>   statics : {
>Index: js/org/eclipse/swt/widgets/Shell.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Shell.js,v
>retrieving revision 1.7
>diff -u -r1.7 Shell.js
>--- js/org/eclipse/swt/widgets/Shell.js	7 Nov 2008 14:03:32 -0000	1.7
>+++ js/org/eclipse/swt/widgets/Shell.js	1 Dec 2008 08:51:38 -0000
>@@ -484,7 +484,8 @@
>       } else {
>         if( this._blocker ) {
>           this.remove( this._blocker );
>-          this._blocker.dispose();
>+//          this._blocker.dispose();
>+          this._blocker.destroy();
>           this._blocker = null;
>         }
>       }
>Index: js/org/eclipse/swt/widgets/TreeColumn.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/TreeColumn.js,v
>retrieving revision 1.3
>diff -u -r1.3 TreeColumn.js
>--- js/org/eclipse/swt/widgets/TreeColumn.js	12 Jun 2008 13:14:28 -0000	1.3
>+++ js/org/eclipse/swt/widgets/TreeColumn.js	1 Dec 2008 08:51:40 -0000
>@@ -68,7 +68,8 @@
>     this.removeEventListener( "mouseout", this._onMouseOut, this );
>     this.removeEventListener( "mousedown", this._onMouseDown, this );
>     this.removeEventListener( "mouseup", this._onMouseUp, this );
>-    this._disposeFields( "_sortImage" );
>+//    this._disposeFields( "_sortImage" );
>+    this._sortImage.destroy();
>     if( !this._tree.getDisposed() ) {
>       this._tree._removeColumn( this );
>     }
>Index: js/org/eclipse/swt/custom/CTabFolder.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/custom/CTabFolder.js,v
>retrieving revision 1.4
>diff -u -r1.4 CTabFolder.js
>--- js/org/eclipse/swt/custom/CTabFolder.js	24 Nov 2008 09:00:07 -0000	1.4
>+++ js/org/eclipse/swt/custom/CTabFolder.js	1 Dec 2008 08:51:38 -0000
>@@ -57,7 +57,9 @@
>     this.removeEventListener( "changeWidth", this._updateLayout, this );
>     this.removeEventListener( "changeHeight", this._updateLayout, this );
>     this.removeEventListener( "keypress", this._onKeyPress, this );
>-    this._disposeObjects( "_frame", "_separator" );
>+    //this._disposeObjects( "_frame", "_separator" );
>+    this._frame.destroy();
>+    this._separator.destroy();
>     this._frameBorder.dispose();
>   },
> 
>Index: js/org/eclipse/swt/custom/CTabItem.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/custom/CTabItem.js,v
>retrieving revision 1.2
>diff -u -r1.2 CTabItem.js
>--- js/org/eclipse/swt/custom/CTabItem.js	12 Jun 2008 13:14:29 -0000	1.2
>+++ js/org/eclipse/swt/custom/CTabItem.js	1 Dec 2008 08:51:38 -0000
>@@ -66,7 +66,8 @@
>       this._closeButton.removeEventListener( "click", this._onClose, this );
>       var wm = org.eclipse.swt.WidgetManager.getInstance();
>       wm.setToolTip( this._closeButton, null );
>-      this._closeButton.dispose();
>+      //this._closeButton.dispose();
>+      this._closeButton.destroy();
>       this._closeButton = null;
>     }
>   },
>Index: js/org/eclipse/swt/WidgetManager.js
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.rap/runtime.rwt/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/WidgetManager.js,v
>retrieving revision 1.4
>diff -u -r1.4 WidgetManager.js
>--- js/org/eclipse/swt/WidgetManager.js	18 Sep 2008 17:21:01 -0000	1.4
>+++ js/org/eclipse/swt/WidgetManager.js	1 Dec 2008 08:51:38 -0000
>@@ -81,7 +81,9 @@
>             typePool.elements.push( widget );
>           // dispose of widgets that cannot be pooled
>           } else {
>-            widget.dispose();
>+            // [if] Replace dispose() with destroy()
>+            // widget.dispose();
>+          	widget.destroy();
>           }
>         }
>       }

Actions: View | Diff

Attachments on bug 257022: 119124 | 119884 | 120035 | 120036 | 120037