Attachment 118765 Details for Bug 256045 – updated patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] updated patch

patch256045.txt (text/plain), 4.43 KB, created by Frank Becker

on 2008-11-26 05:53:16 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Becker

Created: 2008-11-26 05:53:16 EST

Size: 4.43 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.ui
>Index: src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaPeoplePart.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaPeoplePart.java,v
>retrieving revision 1.8
>diff -u -r1.8 BugzillaPeoplePart.java
>--- src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaPeoplePart.java	12 Sep 2008 04:15:33 -0000	1.8
>+++ src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaPeoplePart.java	26 Nov 2008 10:49:15 -0000
>@@ -66,6 +66,10 @@
> 		peopleComposite.setLayout(layout);
> 
> 		addAttribute(peopleComposite, toolkit, getTaskData().getRoot().getMappedAttribute(TaskAttribute.USER_ASSIGNED));
>+		TaskAttribute assignee = getTaskData().getRoot().getAttribute(BugzillaAttribute.SET_DEFAULT_ASSIGNEE.getKey());
>+		if (assignee != null) {
>+			addAttribute(peopleComposite, toolkit, assignee);
>+		}
> 		addAttribute(peopleComposite, toolkit, getTaskData().getRoot().getMappedAttribute(TaskAttribute.USER_REPORTER));
> 		addAttribute(peopleComposite, toolkit, getTaskData().getRoot().getMappedAttribute(
> 				BugzillaAttribute.QA_CONTACT.getKey()));
>#P org.eclipse.mylyn.bugzilla.core
>Index: src/org/eclipse/mylyn/internal/bugzilla/core/RepositoryConfiguration.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/RepositoryConfiguration.java,v
>retrieving revision 1.29
>diff -u -r1.29 RepositoryConfiguration.java
>--- src/org/eclipse/mylyn/internal/bugzilla/core/RepositoryConfiguration.java	12 Sep 2008 04:17:45 -0000	1.29
>+++ src/org/eclipse/mylyn/internal/bugzilla/core/RepositoryConfiguration.java	26 Nov 2008 10:49:17 -0000
>@@ -478,12 +478,30 @@
> 		if (bugzillaVersion == null) {
> 			bugzillaVersion = "2.18";
> 		}
>-		if (bugzillaVersion.compareTo("3.1") < 0
>-				&& (status == BUGZILLA_REPORT_STATUS.NEW || status == BUGZILLA_REPORT_STATUS.ASSIGNED
>-						|| status == BUGZILLA_REPORT_STATUS.REOPENED || status == BUGZILLA_REPORT_STATUS.UNCONFIRMED)) {
>-			// old bugzilla workflow is used
>-			addOperation(bugReport, BugzillaOperation.reassign);
>-			addOperation(bugReport, BugzillaOperation.reassignbycomponent);
>+		if (status == BUGZILLA_REPORT_STATUS.NEW || status == BUGZILLA_REPORT_STATUS.ASSIGNED
>+				|| status == BUGZILLA_REPORT_STATUS.REOPENED || status == BUGZILLA_REPORT_STATUS.UNCONFIRMED) {
>+			if (bugzillaVersion.compareTo("3.1") < 0) {
>+				// old bugzilla workflow is used
>+				addOperation(bugReport, BugzillaOperation.reassign);
>+				addOperation(bugReport, BugzillaOperation.reassignbycomponent);
>+			} else {
>+				BugzillaAttribute key = BugzillaAttribute.SET_DEFAULT_ASSIGNEE;
>+				TaskAttribute operationAttribute = bugReport.getRoot().getAttribute(key.getKey());
>+				if (operationAttribute == null) {
>+					operationAttribute = bugReport.getRoot().createAttribute(key.getKey());
>+					operationAttribute.getMetaData()
>+							.defaults()
>+							.setReadOnly(key.isReadOnly())
>+							.setKind(key.getKind())
>+							.setLabel(key.toString())
>+							.setType(key.getType());
>+					operationAttribute.setValue("0");
>+				}
>+				operationAttribute = bugReport.getRoot().getMappedAttribute(TaskAttribute.USER_ASSIGNED);
>+				if (operationAttribute != null) {
>+					operationAttribute.getMetaData().setReadOnly(false);
>+				}
>+			}
> 		}
> 	}
> 
>Index: src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaAttribute.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.core/src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaAttribute.java,v
>retrieving revision 1.8
>diff -u -r1.8 BugzillaAttribute.java
>--- src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaAttribute.java	4 Nov 2008 06:36:18 -0000	1.8
>+++ src/org/eclipse/mylyn/internal/bugzilla/core/BugzillaAttribute.java	26 Nov 2008 10:49:17 -0000
>@@ -114,8 +114,7 @@
> 
> 	REMAINING_TIME("Remaining:", "remaining_time", TaskAttribute.TYPE_SHORT_TEXT, true, false),
> 
>-	SET_DEFAULT_ASSIGNEE("Reassign to default assignee", "set_default_assignee", TaskAttribute.TYPE_OPERATION, false,
>-			false),
>+	SET_DEFAULT_ASSIGNEE("Reset assignee to default", "set_default_assignee", TaskAttribute.TYPE_BOOLEAN, true, false),
> 
> 	SHORT_DESC("Summary:", "short_desc", TaskAttribute.TYPE_SHORT_RICH_TEXT, true, false),
>

Actions: View | Diff

Attachments on bug 256045: 118414 | 118415 | 118727 | 118765 | 118766