Attachment 118301 Details for Bug 245565 – Test Plugin Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Test Plugin Patch

clipboard.txt (text/plain), 4.83 KB, created by Curtis Windatt

on 2008-11-19 14:08:35 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Curtis Windatt

Created: 2008-11-19 14:08:35 EST

Size: 4.83 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.ui.tests
>Index: src/org/eclipse/pde/ui/tests/imports/BaseImportTestCase.java
>===================================================================
>RCS file: /cvsroot/eclipse/pde/ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/imports/BaseImportTestCase.java,v
>retrieving revision 1.10
>diff -u -r1.10 BaseImportTestCase.java
>--- src/org/eclipse/pde/ui/tests/imports/BaseImportTestCase.java	26 Apr 2008 23:29:07 -0000	1.10
>+++ src/org/eclipse/pde/ui/tests/imports/BaseImportTestCase.java	19 Nov 2008 19:06:13 -0000
>@@ -11,14 +11,13 @@
> package org.eclipse.pde.ui.tests.imports;
> 
> import org.eclipse.core.resources.*;
>-import org.eclipse.core.runtime.*;
>+import org.eclipse.core.runtime.CoreException;
>+import org.eclipse.core.runtime.IStatus;
> import org.eclipse.jdt.core.*;
> import org.eclipse.pde.core.plugin.IPluginModelBase;
> import org.eclipse.pde.core.plugin.PluginRegistry;
> import org.eclipse.pde.internal.core.PDECore;
>-import org.eclipse.pde.internal.ui.PDEPlugin;
> import org.eclipse.pde.internal.ui.wizards.imports.PluginImportOperation;
>-import org.eclipse.pde.internal.ui.wizards.imports.PluginImportWizard.ImportQuery;
> import org.eclipse.pde.ui.tests.PDETestCase;
> 
> public abstract class BaseImportTestCase extends PDETestCase {
>@@ -68,16 +67,18 @@
> 	}
> 	
> 	protected void runOperation(IPluginModelBase[] models, int type) {
>-		PluginImportOperation.IImportQuery query = new ImportQuery(getShell());
>-		PluginImportOperation.IImportQuery executionQuery = new ImportQuery(getShell());
>-		final PluginImportOperation op = new PluginImportOperation(models, type, query, executionQuery, false);
>-
>-		try {
>-			PDEPlugin.getWorkspace().run(op, new NullProgressMonitor());
>-		} catch (OperationCanceledException e) {
>-			fail("Import Operation failed: " + e);
>-		} catch (CoreException e) {
>-			fail("Import Operation failed: " + e);
>+		PluginImportOperation job = new PluginImportOperation(models, type, false);
>+		job.setRule(ResourcesPlugin.getWorkspace().getRoot());
>+		job.setSystem(true);
>+		job.schedule();
>+		try{
>+			job.join();
>+		} catch (InterruptedException e){
>+			fail("Job interupted: " + e.getMessage());
>+		}
>+		IStatus status = job.getResult();
>+		if (!status.isOK()){
>+			fail("Import Operation failed: " + status.toString());
> 		}
> 	}
> 
>Index: .settings/org.eclipse.jdt.core.prefs
>===================================================================
>RCS file: /cvsroot/eclipse/pde/ui/org.eclipse.pde.ui.tests/.settings/org.eclipse.jdt.core.prefs,v
>retrieving revision 1.9
>diff -u -r1.9 org.eclipse.jdt.core.prefs
>--- .settings/org.eclipse.jdt.core.prefs	24 Mar 2008 16:26:00 -0000	1.9
>+++ .settings/org.eclipse.jdt.core.prefs	19 Nov 2008 19:06:13 -0000
>@@ -1,4 +1,4 @@
>-#Mon Mar 24 11:13:46 CDT 2008
>+#Tue Nov 18 10:52:33 CST 2008
> eclipse.preferences.version=1
> org.eclipse.jdt.core.builder.cleanOutputFolder=clean
> org.eclipse.jdt.core.builder.duplicateResourceTask=warning
>@@ -20,10 +20,11 @@
> org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
> org.eclipse.jdt.core.compiler.problem.assertIdentifier=warning
> org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
>+org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning
> org.eclipse.jdt.core.compiler.problem.deprecation=warning
> org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
> org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=enabled
>-org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
>+org.eclipse.jdt.core.compiler.problem.discouragedReference=ignore
> org.eclipse.jdt.core.compiler.problem.emptyStatement=warning
> org.eclipse.jdt.core.compiler.problem.enumIdentifier=warning
> org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore
>@@ -41,6 +42,7 @@
> org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
> org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
> org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore
>+org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore
> org.eclipse.jdt.core.compiler.problem.missingJavadocComments=ignore
> org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsOverriding=enabled
> org.eclipse.jdt.core.compiler.problem.missingJavadocCommentsVisibility=public
>@@ -49,6 +51,7 @@
> org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=public
> org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
> org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning
>+org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore
> org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning
> org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning
> org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore

Actions: View | Diff

Attachments on bug 245565: 117150 | 117151 | 117958 | 118301