Attachment 117570 Details for Bug 254921 – Hopefully fixes the subj

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Hopefully fixes the subj

254921.patch (text/plain), 1.05 KB, created by Michael Golubev

on 2008-11-11 12:45:39 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Golubev

Created: 2008-11-11 12:45:39 EST

Size: 1.05 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.gmf.runtime.diagram.ui
>Index: src/org/eclipse/gmf/runtime/diagram/ui/tools/PopupBarTool.java
>===================================================================
>RCS file: /cvsroot/modeling/org.eclipse.gmf/plugins/org.eclipse.gmf.runtime.diagram.ui/src/org/eclipse/gmf/runtime/diagram/ui/tools/PopupBarTool.java,v
>retrieving revision 1.6
>diff -u -r1.6 PopupBarTool.java
>--- src/org/eclipse/gmf/runtime/diagram/ui/tools/PopupBarTool.java	3 Oct 2006 15:02:05 -0000	1.6
>+++ src/org/eclipse/gmf/runtime/diagram/ui/tools/PopupBarTool.java	11 Nov 2008 17:45:10 -0000
>@@ -100,7 +100,11 @@
> 			((CreateRequest) theRequest).setLocation(thePoint);
> 		}
> 
>-		Command theCmd = getHost().getCommand(theRequest);
>+		EditPart target = getHost().getTargetEditPart(theRequest);
>+		if (target == null){
>+			target = getHost();
>+		}
>+		Command theCmd = target.getCommand(theRequest);
> 		// if we return a cmd that cannot execute then later downstream an
> 		// NPE can be generated.
> 		if (theCmd != null && theCmd.canExecute()) {

Actions: View | Diff

Attachments on bug 254921: 117570