Attachment 117485 Details for Bug 253977 – Revised patch containing Boris' suggestions

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Revised patch containing Boris' suggestions

patch(253977) (text/plain), 1.61 KB, created by Eric Moffatt

on 2008-11-10 16:23:04 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Moffatt

Created: 2008-11-10 16:23:04 EST

Size: 1.61 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.views
>Index: META-INF/MANIFEST.MF
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.views/META-INF/MANIFEST.MF,v
>retrieving revision 1.13
>diff -u -r1.13 MANIFEST.MF
>--- META-INF/MANIFEST.MF	3 Mar 2008 03:31:38 -0000	1.13
>+++ META-INF/MANIFEST.MF	10 Nov 2008 21:21:29 -0000
>@@ -2,7 +2,7 @@
> Bundle-ManifestVersion: 2
> Bundle-Name: %pluginName
> Bundle-SymbolicName: org.eclipse.ui.views; singleton:=true
>-Bundle-Version: 3.3.0.qualifier
>+Bundle-Version: 3.3.1.qualifier
> Bundle-ClassPath: .
> Bundle-Activator: org.eclipse.ui.internal.views.ViewsPlugin
> Bundle-ActivationPolicy: lazy
>Index: src/org/eclipse/ui/views/properties/PropertySheet.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheet.java,v
>retrieving revision 1.16
>diff -u -r1.16 PropertySheet.java
>--- src/org/eclipse/ui/views/properties/PropertySheet.java	9 May 2008 14:12:53 -0000	1.16
>+++ src/org/eclipse/ui/views/properties/PropertySheet.java	10 Nov 2008 21:21:29 -0000
>@@ -167,7 +167,9 @@
>      * The property sheet may show properties for any view other than this view.
>      */
>     protected boolean isImportant(IWorkbenchPart part) {
>-        return part != this;
>+    	// Hack! See Bug 253977...explicitly exclude the Help view as a participant
>+    	boolean isHelpView = "org.eclipse.help.ui.HelpView".equals(part.getSite().getId()); //$NON-NLS-1$
>+        return part != this && !isHelpView;
>     }
> 
>     /**

Actions: View | Diff

Attachments on bug 253977: 117247 | 117485