Attachment 117445 Details for Bug 252707 – Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch

patch.txt (text/plain), 2.88 KB, created by Kevin Doyle

on 2008-11-10 10:56:12 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Kevin Doyle

Created: 2008-11-10 10:56:12 EST

Size: 2.88 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.useractions
>Index: src/org/eclipse/rse/internal/useractions/api/ui/compile/SystemCompileAction.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/ui/compile/SystemCompileAction.java,v
>retrieving revision 1.1
>diff -u -r1.1 SystemCompileAction.java
>--- src/org/eclipse/rse/internal/useractions/api/ui/compile/SystemCompileAction.java	6 May 2008 07:38:56 -0000	1.1
>+++ src/org/eclipse/rse/internal/useractions/api/ui/compile/SystemCompileAction.java	10 Nov 2008 15:54:26 -0000
>@@ -10,6 +10,7 @@
>  * Martin Oberhuber (Wind River) - [168870] refactor org.eclipse.rse.core package of the UI plugin
>  * David Dykstal (IBM) - [186589] move user actions API out of org.eclipse.rse.ui
>  * David McKnight   (IBM)        - [225506] [api][breaking] RSE UI leaks non-API types
>+ * Kevin Doyle		(IBM)		 - [252707] Everytime a Compile command is selected a saving profile job is performed
>  *******************************************************************************/
> package org.eclipse.rse.internal.useractions.api.ui.compile;
> 
>@@ -124,14 +125,11 @@
> 			Object element = getFirstSelection();
> 			boolean ok = true;
> 			while (ok && (element != null)) {
>-				/* FIXME - compile actions not coupled with subsystem API anymore
>-				 ISystemRemoteElementAdapter rmtAdapter = SystemAdapterHelpers.getRemoteAdapter(element);
>-				 ISubSystem ss = rmtAdapter.getSubSystem(element);
>-				 ss.getParentSubSystemFactory().getCompileManager().setSystemConnection(ss.getHost());
>-				 */
> 				SystemCompileType compType = compileCmd.getParentType();
>-				compType.setLastUsedCompileCommand(compileCmd);
>-				compType.getParentProfile().writeToDisk();
>+				if (!compileCmd.equals(compType.getLastUsedCompileCommand())) {
>+					compType.setLastUsedCompileCommand(compileCmd);
>+					compType.getParentProfile().writeToDisk();
>+				}
> 				SystemCompilableSource compilableSrc = compType.getParentProfile().getCompilableSourceObject(getShell(), element, compileCmd, isPrompt, viewer);
> 				ok = compilableSrc.runCompileCommand();
> 				if (ok) element = getNextSelection();
>@@ -189,10 +187,8 @@
> 			}
> 			WorkbenchContentProvider cprovider = new WorkbenchContentProvider();
> 			SystemTableViewProvider lprovider = new SystemTableViewProvider(null);
>-			// TODO: Cannot use WorkbenchMessages -- it's internal
> 			ListSelectionDialog dlg = new ListSelectionDialog(getShell(), input, cprovider, lprovider, SystemUDAResources.EditorManager_saveResourcesMessage);
> 			dlg.setInitialSelections(input.getChildren());
>-			// TODO: Cannot use WorkbenchMessages -- it's internal
> 			dlg.setTitle(SystemUDAResources.EditorManager_saveResourcesTitle);
> 			int result = dlg.open();
> 			//Just return false to prevent the operation continuing

Actions: View | Diff

Attachments on bug 252707: 117445