Attachment 117232 Details for Bug 252283 – Suggested fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Suggested fix

zpatch.txt (text/plain), 3.62 KB, created by Marc Khouzam

on 2008-11-06 13:42:09 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Khouzam

Created: 2008-11-06 13:42:09 EST

Size: 3.62 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dd.mi
>Index: src/org/eclipse/dd/mi/service/command/commands/MITargetSelect.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/command/commands/MITargetSelect.java,v
>retrieving revision 1.3
>diff -u -r1.3 MITargetSelect.java
>--- src/org/eclipse/dd/mi/service/command/commands/MITargetSelect.java	18 Aug 2008 00:37:32 -0000	1.3
>+++ src/org/eclipse/dd/mi/service/command/commands/MITargetSelect.java	6 Nov 2008 18:38:42 -0000
>@@ -18,12 +18,28 @@
>  */
> public class MITargetSelect extends MICommand<MIInfo> {
> 
>+	@Deprecated
> 	public MITargetSelect(IDMContext ctx, String host, String port) {
>-		super(ctx, "-target-select extended-remote", new String[] {host + ":" + port}); //$NON-NLS-1$ //$NON-NLS-2$
>+		this(ctx, host, port, true);
> 	}
> 	
>+	@Deprecated	
> 	public MITargetSelect(IDMContext ctx, String serialDevice) {
>-		super(ctx, "-target-select extended-remote", new String[] {serialDevice}); //$NON-NLS-1$
>+		this(ctx, serialDevice, true);
>+	}
>+
>+	/**
>+	 * @since 1.1
>+	 */
>+	public MITargetSelect(IDMContext ctx, String host, String port, boolean extended) {
>+		super(ctx, "-target-select", new String[] { extended ? "extended-remote" : "remote", host + ":" + port}); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$
>+	}
>+	
>+	/**
>+	 * @since 1.1
>+	 */
>+	public MITargetSelect(IDMContext ctx, String serialDevice, boolean extended) {
>+		super(ctx, "-target-select extended-remote", new String[] { extended ? "extended-remote" : "remote", serialDevice}); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
> 	}
> 
> }
>#P org.eclipse.dd.gdb
>Index: src/org/eclipse/dd/gdb/internal/provisional/launching/FinalLaunchSequence.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.gdb/src/org/eclipse/dd/gdb/internal/provisional/launching/FinalLaunchSequence.java,v
>retrieving revision 1.37
>diff -u -r1.37 FinalLaunchSequence.java
>--- src/org/eclipse/dd/gdb/internal/provisional/launching/FinalLaunchSequence.java	5 Nov 2008 22:35:48 -0000	1.37
>+++ src/org/eclipse/dd/gdb/internal/provisional/launching/FinalLaunchSequence.java	6 Nov 2008 18:38:43 -0000
>@@ -398,14 +398,14 @@
>                     
>                         fCommandControl.queueCommand(
>                         		new MITargetSelect(fCommandControl.getContext(), 
>-                        				           fRemoteTcpHost, fRemoteTcpPort), 
>+                        				           fRemoteTcpHost, fRemoteTcpPort, fAttach), 
>                         	    new DataRequestMonitor<MIInfo>(getExecutor(), requestMonitor));
>                		} else {
>                			if (!getSerialDevice(requestMonitor)) return;
>                     
>                         fCommandControl.queueCommand(
>                         		new MITargetSelect(fCommandControl.getContext(), 
>-                        				           fSerialDevice), 
>+                        				           fSerialDevice, fAttach), 
>                         	    new DataRequestMonitor<MIInfo>(getExecutor(), requestMonitor));
>                		}
>             	} else {
>@@ -489,7 +489,7 @@
>     DsfServicesTracker fTracker;
>         
>     public FinalLaunchSequence(DsfExecutor executor, GdbLaunch launch, SessionType sessionType, boolean attach, IProgressMonitor pm) {
>-        super(executor, pm, "Configuring GDB", "Aborting configuring GDB");  
>+        super(executor, pm, "Configuring GDB", "Aborting configuring GDB");    //$NON-NLS-1$//$NON-NLS-2$
>         fLaunch = launch;
>         fSessionType = sessionType;
>         fAttach = attach;

Actions: View | Diff

Attachments on bug 252283: 116231 | 117232 | 117776