Attachment 11626 Details for Bug 65464 – Patch to IDE using different selection provider

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to IDE using different selection provider

65464_ide_patch.txt (text/plain), 3.89 KB, created by Nick Edgar

on 2004-06-04 23:28:13 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Edgar

Created: 2004-06-04 23:28:13 EDT

Size: 3.89 KB

patch

obsolete

>Index: src/org/eclipse/ui/views/markers/internal/MarkerView.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/MarkerView.java,v
>retrieving revision 1.17
>diff -u -r1.17 MarkerView.java
>--- src/org/eclipse/ui/views/markers/internal/MarkerView.java	26 May 2004 21:10:57 -0000	1.17
>+++ src/org/eclipse/ui/views/markers/internal/MarkerView.java	5 Jun 2004 03:19:44 -0000
>@@ -37,10 +37,13 @@
> import org.eclipse.core.runtime.jobs.Job;
> import org.eclipse.jface.action.IMenuManager;
> import org.eclipse.jface.action.IToolBarManager;
>+import org.eclipse.jface.action.MenuManager;
> import org.eclipse.jface.action.Separator;
> import org.eclipse.jface.operation.IRunnableWithProgress;
> import org.eclipse.jface.util.Assert;
> import org.eclipse.jface.viewers.ISelection;
>+import org.eclipse.jface.viewers.ISelectionChangedListener;
>+import org.eclipse.jface.viewers.ISelectionProvider;
> import org.eclipse.jface.viewers.IStructuredSelection;
> import org.eclipse.jface.viewers.OpenEvent;
> import org.eclipse.jface.viewers.StructuredSelection;
>@@ -780,5 +783,36 @@
>     	uiJob.setPriority(Job.INTERACTIVE);
> 		uiJob.setSystem(true);
>     }
>-	
>+
>+    /**
>+     * Registers the menu manager with the view site, in such a way
>+     * that the workbench object contribution mechanism sees <code>IMarker</code>
>+     * instances as the selected objects, not <code>ConcreteMarker</code>s.  
>+     * 
>+     * @since 3.0
>+     */
>+    protected void registerContextMenu(MenuManager mgr) {
>+        ISelectionProvider selProv = new ISelectionProvider() {
>+            public void addSelectionChangedListener(
>+                    ISelectionChangedListener listener) {
>+                // not used
>+            }
>+            public ISelection getSelection() {
>+                IStructuredSelection ssel = (IStructuredSelection) getViewer().getSelection();
>+                ArrayList markers = new ArrayList(ssel.size());
>+                for (Iterator i = ssel.iterator(); i.hasNext();) {
>+                    ConcreteMarker cm = (ConcreteMarker) i.next();
>+                    markers.add(cm.getMarker());
>+                }
>+                return new StructuredSelection(markers);
>+            }
>+            public void removeSelectionChangedListener(ISelectionChangedListener listener) {
>+                // not used
>+            }
>+            public void setSelection(ISelection selection) {
>+                // not used
>+            }
>+        };
>+        getSite().registerContextMenu(mgr, selProv);
>+    }
> }
>Index: src/org/eclipse/ui/views/markers/internal/TableView.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.ide/src/org/eclipse/ui/views/markers/internal/TableView.java,v
>retrieving revision 1.3
>diff -u -r1.3 TableView.java
>--- src/org/eclipse/ui/views/markers/internal/TableView.java	19 Feb 2004 15:19:47 -0000	1.3
>+++ src/org/eclipse/ui/views/markers/internal/TableView.java	5 Jun 2004 03:19:45 -0000
>@@ -157,7 +157,7 @@
> 		Menu menu = mgr.createContextMenu(viewer.getControl());
> 		
> 		viewer.getControl().setMenu(menu);
>-		getSite().registerContextMenu(mgr, viewer);
>+		registerContextMenu(mgr);
> 		initActionBars(getViewSite().getActionBars());
> 		registerGlobalActions(getViewSite().getActionBars());
> 		
>@@ -174,6 +174,18 @@
> 	}
> 	
> 	/**
>+     * Registers the newly created menu manager with the view's site.
>+     * The default implementation uses the viewer as the registered selection provider.
>+     * 
>+     * @param mgr the menu manager to register
>+     * 
>+     * @since 3.0
>+     */
>+    protected void registerContextMenu(MenuManager mgr) {
>+        getSite().registerContextMenu(mgr, viewer);
>+    }
>+
>+    /**
> 	 * @param selection
> 	 */
> 	protected void setSelection(IStructuredSelection selection) {

Actions: View | Diff

Attachments on bug 65464: 11522 | 11626