Attachment 115823 Details for Bug 251679 – Proposed fix

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed fix

patch_251679.txt (text/plain), 1.31 KB, created by Olivier Thomann

on 2008-10-22 11:27:42 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2008-10-22 11:27:42 EDT

Size: 1.31 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.api.tools
>Index: src/org/eclipse/pde/api/tools/internal/util/Util.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/util/Util.java,v
>retrieving revision 1.81
>diff -u -r1.81 Util.java
>--- src/org/eclipse/pde/api/tools/internal/util/Util.java	22 Oct 2008 14:00:00 -0000	1.81
>+++ src/org/eclipse/pde/api/tools/internal/util/Util.java	22 Oct 2008 14:52:12 -0000
>@@ -2578,9 +2578,16 @@
> 		if (Signature.getArrayCount(type) == Signature.getArrayCount(type2)) {
> 			String el1 = Signature.getElementType(type);
> 			String el2 = Signature.getElementType(type2);
>-			if (Signature.getSignatureSimpleName(el1).equals(Signature.getSignatureSimpleName(el2))) {
>+			String signatureSimpleName = Signature.getSignatureSimpleName(el1);
>+			String signatureSimpleName2 = Signature.getSignatureSimpleName(el2);
>+			if (signatureSimpleName.equals(signatureSimpleName2)) {
> 				return true;
> 			}
>+			int index = signatureSimpleName2.lastIndexOf('.');
>+			if (index != -1) {
>+				// the right side is a member type
>+				return signatureSimpleName.equals(signatureSimpleName2.subSequence(index + 1, signatureSimpleName2.length()));
>+			}
> 		}
> 		return false;
> 	}

Actions: View | Diff

Attachments on bug 251679: 115823