Attachment 114640 Details for Bug 233111 – Patch with fix.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch with fix.

20081008_233111.patch (text/plain), 2.06 KB, created by Pawel Piech

on 2008-10-09 01:33:45 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Pawel Piech

Created: 2008-10-09 01:33:45 EDT

Size: 2.06 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dd.dsf.debug.ui
>Index: src/org/eclipse/dd/dsf/debug/internal/provisional/ui/viewmodel/expression/WatchExpressionCellModifier.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.dd.dsf/plugins/org.eclipse.dd.dsf.debug.ui/src/org/eclipse/dd/dsf/debug/internal/provisional/ui/viewmodel/expression/WatchExpressionCellModifier.java,v
>retrieving revision 1.2
>diff -u -r1.2 WatchExpressionCellModifier.java
>--- src/org/eclipse/dd/dsf/debug/internal/provisional/ui/viewmodel/expression/WatchExpressionCellModifier.java	30 May 2008 22:57:39 -0000	1.2
>+++ src/org/eclipse/dd/dsf/debug/internal/provisional/ui/viewmodel/expression/WatchExpressionCellModifier.java	9 Oct 2008 05:32:19 -0000
>@@ -53,13 +53,18 @@
>     public void modify(Object element, String property, Object value) {
>         if (!IDebugVMConstants.COLUMN_ID__EXPRESSION.equals(property)) return;
>         if (!(value instanceof String)) return;
>-
>+        
>+        String strValue = ((String)value).trim();
>         IWatchExpression expression = getWatchExpression(element);
>+        IExpressionManager expressionManager = DebugPlugin.getDefault().getExpressionManager(); 
>         if (expression != null) {
>-            expression.setExpressionText((String)value);
>-        } else if (element instanceof NewExpressionVMC && ((String)value).trim().length() != 0) {
>-            IExpressionManager expressionManager = DebugPlugin.getDefault().getExpressionManager(); 
>-            IWatchExpression watchExpression = expressionManager.newWatchExpression((String)value); 
>+            if (strValue.length() != 0) {
>+                expression.setExpressionText(strValue);
>+            } else {
>+                expressionManager.removeExpression(expression);
>+            }
>+        } else if (element instanceof NewExpressionVMC && strValue.length() != 0) {
>+            IWatchExpression watchExpression = expressionManager.newWatchExpression(strValue); 
>             expressionManager.addExpression(watchExpression);            
>         }
>     }

Flags:

cdtdoug: iplog-

Actions: View | Diff

Attachments on bug 233111: 114640