Attachment 112830 Details for Bug 247736 – a patch fixed the expend all button

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] a patch fixed the expend all button

clipboard.txt (text/plain), 2.10 KB, created by Jingwen 'Owen' Ou

on 2008-09-17 17:07:42 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jingwen 'Owen' Ou

Created: 2008-09-17 17:07:42 EDT

Size: 2.10 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.sandbox.ui
>Index: src/org/eclipse/mylyn/internal/sandbox/ui/editors/ExtensibleTaskEditorCommentPart.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/sandbox/org.eclipse.mylyn.sandbox.ui/src/org/eclipse/mylyn/internal/sandbox/ui/editors/ExtensibleTaskEditorCommentPart.java,v
>retrieving revision 1.2
>diff -u -r1.2 ExtensibleTaskEditorCommentPart.java
>--- src/org/eclipse/mylyn/internal/sandbox/ui/editors/ExtensibleTaskEditorCommentPart.java	12 Sep 2008 04:20:03 -0000	1.2
>+++ src/org/eclipse/mylyn/internal/sandbox/ui/editors/ExtensibleTaskEditorCommentPart.java	17 Sep 2008 21:06:14 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>-* Copyright (c) 2004, 2008 Tasktop Technologies and others.
>+ * Copyright (c) 2004, 2008 Tasktop Technologies and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -154,22 +154,24 @@
> 
> 	@Override
> 	protected void expandAllComments() {
>-		// first toggle on all subSections
>-		try {
>-			getTaskEditorPage().setReflow(false);
>+		if (subSections != null) {
>+			// first toggle on all subSections
>+			try {
>+				getTaskEditorPage().setReflow(false);
> 
>-			if (section != null) {
>-				EditorUtil.toggleExpandableComposite(true, section);
>-			}
>+				if (section != null) {
>+					EditorUtil.toggleExpandableComposite(true, section);
>+				}
> 
>-			for (Section subSection : subSections) {
>-				if (subSection.isDisposed()) {
>-					continue;
>+				for (Section subSection : subSections) {
>+					if (subSection.isDisposed()) {
>+						continue;
>+					}
>+					EditorUtil.toggleExpandableComposite(true, subSection);
> 				}
>-				EditorUtil.toggleExpandableComposite(true, subSection);
>+			} finally {
>+				getTaskEditorPage().setReflow(true);
> 			}
>-		} finally {
>-			getTaskEditorPage().setReflow(true);
> 		}
> 
> 		super.expandAllComments();

Actions: View | Diff

Attachments on bug 247736: 112830 | 112831