Attachment 112591 Details for Bug 97786 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

patch-97786.txt (text/plain), 1.78 KB, created by Boris Bokowski

on 2008-09-15 15:30:08 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Boris Bokowski

Created: 2008-09-15 15:30:08 EDT

Size: 1.78 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface
>Index: src/org/eclipse/jface/viewers/TableViewer.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface/src/org/eclipse/jface/viewers/TableViewer.java,v
>retrieving revision 1.91
>diff -u -r1.91 TableViewer.java
>--- src/org/eclipse/jface/viewers/TableViewer.java	13 May 2008 20:56:13 -0000	1.91
>+++ src/org/eclipse/jface/viewers/TableViewer.java	15 Sep 2008 19:29:34 -0000
>@@ -370,4 +370,42 @@
> 	public void refresh(boolean updateLabels, boolean reveal) {
> 		refresh(getRoot(), updateLabels, reveal);
> 	}
>+	
>+	/* (non-Javadoc)
>+	 * @see org.eclipse.jface.viewers.AbstractTableViewer#remove(java.lang.Object[])
>+	 */
>+	public void remove(Object[] elements) {
>+		assertElementsNotNull(elements);
>+		if (checkBusy())
>+			return;
>+		if (elements.length == 0) {
>+			return;
>+		}
>+		// deselect any items that are being removed, see bug 97786
>+		Object elementToBeRemoved = null;
>+		CustomHashtable elementsToBeRemoved = null;
>+		if (elements.length == 1) {
>+			elementToBeRemoved = elements[0];
>+		} else {
>+			elementsToBeRemoved = new CustomHashtable(getComparer());
>+			for (int i = 0; i < elements.length; i++) {
>+				Object element = elements[i];
>+				elementsToBeRemoved.put(element, element);
>+			}
>+		}
>+		int[] selectionIndices = doGetSelectionIndices();
>+		for (int i = 0; i < selectionIndices.length; i++) {
>+			int index = selectionIndices[i];
>+			Item item = doGetItem(index);
>+			Object data = item.getData();
>+			if (data != null) {
>+				if ((elementsToBeRemoved != null && elementsToBeRemoved
>+						.containsKey(data))
>+						|| equals(elementToBeRemoved, data)) {
>+					table.deselect(index);
>+				}
>+			}
>+		}
>+		super.remove(elements);
>+	}
> }

Actions: View | Diff

Attachments on bug 97786: 112591