Attachment 11229 Details for Bug 64043 – Patch to solve NPE problem

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to solve NPE problem

editor_npe_patch.txt (text/plain), 1.59 KB, created by Ines Khelifi

on 2004-05-27 14:26:12 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ines Khelifi

Created: 2004-05-27 14:26:12 EDT

Size: 1.59 KB

patch

obsolete

>Index: Eclipse UI/org/eclipse/ui/internal/EditorManager.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/EditorManager.java,v
>retrieving revision 1.41
>diff -u -r1.41 EditorManager.java
>--- Eclipse UI/org/eclipse/ui/internal/EditorManager.java	26 May 2004 18:22:11 -0000	1.41
>+++ Eclipse UI/org/eclipse/ui/internal/EditorManager.java	27 May 2004 18:06:46 -0000
>@@ -40,6 +40,7 @@
> import org.eclipse.jface.window.ApplicationWindow;
> import org.eclipse.swt.custom.BusyIndicator;
> import org.eclipse.swt.program.Program;
>+import org.eclipse.swt.widgets.Control;
> import org.eclipse.swt.widgets.Display;
> import org.eclipse.ui.IEditorActionBarContributor;
> import org.eclipse.ui.IEditorInput;
>@@ -798,7 +799,13 @@
> 					String workbookID = ref.getMemento().getString(IWorkbenchConstants.TAG_WORKBOOK);
> 					editorPresentation.setActiveEditorWorkbookFromID(workbookID);
> 					openInternalEditor(ref, desc, editorInput, false);
>-					ref.getPane().createChildControl();
>+					
>+					Control ctrl = ref.getPane().getControl();
>+                    if (ctrl == null)
>+                    	ref.getPane().createControl(page.getClientComposite());
>+                    else 
>+                    	ref.getPane().createChildControl();
>+                    
> 					// TODO commented during presentation refactor ((EditorPane)ref.getPane()).getWorkbook().updateEditorTab(ref);
> 				} catch (PartInitException e) {
> 					WorkbenchPlugin.log("Exception creating editor: " + e.getMessage()); //$NON-NLS-1$

Actions: View | Diff

Attachments on bug 64043: 11229 | 11536