Attachment 112010 Details for Bug 246270 – proposed patch - HEAD stream

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] proposed patch - HEAD stream

246270.txt (text/plain), 1.56 KB, created by Karen Butzke

on 2008-09-08 15:56:05 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Karen Butzke

Created: 2008-09-08 15:56:05 EDT

Size: 1.56 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.datatools.connectivity
>Index: src/org/eclipse/datatools/connectivity/internal/InternalProfileManager.java
>===================================================================
>RCS file: /cvsroot/datatools/org.eclipse.datatools.connectivity/plugins/org.eclipse.datatools.connectivity/src/org/eclipse/datatools/connectivity/internal/InternalProfileManager.java,v
>retrieving revision 1.26
>diff -u -r1.26 InternalProfileManager.java
>--- src/org/eclipse/datatools/connectivity/internal/InternalProfileManager.java	8 Aug 2008 19:31:43 -0000	1.26
>+++ src/org/eclipse/datatools/connectivity/internal/InternalProfileManager.java	8 Sep 2008 19:52:39 -0000
>@@ -136,13 +136,7 @@
> 		
> 		if (mProfiles == null) 
> 		{
>-			if (loadProfiles()) 
>-			{
>-				for (int profileIndex = 0, totalProfiles = mProfiles.length; profileIndex < totalProfiles; profileIndex++) 
>-				{
>-					fireProfileAdded(mProfiles[profileIndex]);
>-				}
>-			}
>+			loadProfiles();
> 		}
> 		
> 		cps.addAll(Arrays.asList(mProfiles));
>@@ -903,10 +897,10 @@
> 		mProfileListeners.remove(listener);
> 	}
> 
>-	private synchronized boolean loadProfiles() {
>+	private synchronized void loadProfiles() {
> 		if (mProfiles != null )
> 		{
>-			return false;
>+			return;
> 		}
> 		File serverFile = ConnectivityPlugin.getDefault().getStateLocation()
> 				.append(ConnectionProfileMgmt.FILENAME).toFile();
>@@ -1006,7 +1000,6 @@
> 
> 		autoConnectProfiles();
> 		addProfileListener(mProfileChangeListener);
>-		return true;
> 	}
> 	
> 	private void backupProfilesData ( File ioFile ) {

Actions: View | Diff

Attachments on bug 246270: 112010