Attachment #111631 for bug #244092

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Lines 404-410 Link Here

(-)src/org/eclipse/mylyn/internal/tasks/core/AbstractTask.java (-1 / +1 lines)
404	*/	404	*/
405	@Deprecated	405	@Deprecated
406	public boolean isPastReminder() {	406	public boolean isPastReminder() {
407	if (isCompleted() \|\| scheduledForDate == null) {	407	if (isCompleted() \|\| scheduledForDate == null \|\| !getScheduledForDate().isDay()) {
408	return false;	408	return false;
409	} else {	409	} else {
410	if (/!internalIsFloatingScheduledDate() && /scheduledForDate.getEndDate().compareTo(	410	if (/!internalIsFloatingScheduledDate() && /scheduledForDate.getEndDate().compareTo(




//			if (!TasksUiPlugin.getTaskActivityManager().isWeekDay((ScheduledTaskContainer) parent)) {
//				return false;
//			}
			if (TasksUiPlugin.getTaskActivityManager().isOverdue(task)
					|| TasksUiPlugin.getTaskActivityManager().isPastReminder((AbstractTask) task)) {
				return true;
			}


		if (parent instanceof ScheduledTaskContainer) {
			return shouldShowInFocusedWorkweekDateContainer(parent, task);
		} else {
			return TasksUiPlugin.getTaskActivityManager().isPastReminder(task)
					|| TasksUiPlugin.getTaskActivityManager().isScheduledForThisWeek(task)
					|| TasksUiPlugin.getTaskActivityManager().isDueThisWeek(task)
					|| TasksUiPlugin.getTaskActivityManager().isScheduledForToday(task);
		}

Lines 273-279 Link Here

(-)src/org/eclipse/mylyn/internal/tasks/ui/TasksUiPlugin.java (-1 / +1 lines)
273	Collection<AbstractTask> allTasks = TasksUiPlugin.getTaskList().getAllTasks();	273	Collection<AbstractTask> allTasks = TasksUiPlugin.getTaskList().getAllTasks();
274	Set<AbstractNotification> reminders = new HashSet<AbstractNotification>();	274	Set<AbstractNotification> reminders = new HashSet<AbstractNotification>();
275	for (AbstractTask task : allTasks) {	275	for (AbstractTask task : allTasks) {
276	if (task.isPastReminder() && !task.isReminded()) {	276	if (TasksUiPlugin.getTaskActivityManager().isPastReminder(task) && !task.isReminded()) {
277	reminders.add(new TaskListNotificationReminder(task));	277	reminders.add(new TaskListNotificationReminder(task));
278	task.setReminded(true);	278	task.setReminded(true);
279	}	279	}

Return to bug 244092

Lines 126-132 Link Here

(-)src/org/eclipse/mylyn/internal/tasks/ui/views/TaskListInterestFilter.java (-2 / +4 lines)
126	// if (!TasksUiPlugin.getTaskActivityManager().isWeekDay((ScheduledTaskContainer) parent)) {	126	// if (!TasksUiPlugin.getTaskActivityManager().isWeekDay((ScheduledTaskContainer) parent)) {
127	// return false;	127	// return false;
128	// }	128	// }
129	if (TasksUiPlugin.getTaskActivityManager().isOverdue(task) \|\| ((AbstractTask) task).isPastReminder()) {	129	if (TasksUiPlugin.getTaskActivityManager().isOverdue(task)
		130	\|\| TasksUiPlugin.getTaskActivityManager().isPastReminder((AbstractTask) task)) {
130	return true;	131	return true;
131	}	132	}
132		133
Lines 139-145 Link Here
139	if (parent instanceof ScheduledTaskContainer) {	140	if (parent instanceof ScheduledTaskContainer) {
140	return shouldShowInFocusedWorkweekDateContainer(parent, task);	141	return shouldShowInFocusedWorkweekDateContainer(parent, task);
141	} else {	142	} else {
142	return task.isPastReminder() \|\| TasksUiPlugin.getTaskActivityManager().isScheduledForThisWeek(task)	143	return TasksUiPlugin.getTaskActivityManager().isPastReminder(task)
		144	\|\| TasksUiPlugin.getTaskActivityManager().isScheduledForThisWeek(task)
143	\|\| TasksUiPlugin.getTaskActivityManager().isDueThisWeek(task)	145	\|\| TasksUiPlugin.getTaskActivityManager().isDueThisWeek(task)
144	\|\| TasksUiPlugin.getTaskActivityManager().isScheduledForToday(task);	146	\|\| TasksUiPlugin.getTaskActivityManager().isScheduledForToday(task);
145	}	147	}