Attachment 110940 Details for Bug 244004 – Add support for set/get cursor of Combo widget.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Add support for set/get cursor of Combo widget.

Cursor_Combo_Patch.txt (text/plain), 3.98 KB, created by Ivan Furnadjiev

on 2008-08-26 10:42:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Furnadjiev

Created: 2008-08-26 10:42:43 EDT

Size: 3.98 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rap.rwt.q07
>Index: js/org/eclipse/swt/widgets/Combo.js
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.rap/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/widgets/Combo.js,v
>retrieving revision 1.7
>diff -u -r1.7 Combo.js
>--- js/org/eclipse/swt/widgets/Combo.js	5 Aug 2008 09:14:21 -0000	1.7
>+++ js/org/eclipse/swt/widgets/Combo.js	26 Aug 2008 14:30:35 -0000
>@@ -17,15 +17,17 @@
> 
>   construct : function() {
>     this.base( arguments );
>-    this.rap_init();
>+    this.rap_init();    
>   },
> 
>   members : {
>-    rap_init : function() { 
>+    rap_init : function() {
>+      this._userCursor = null;
>       this.addEventListener( "changeFont", this._rwt_onChangeFont, this );
>       this.addEventListener( "changeTextColor", this._rwt_onChangeTextColor, this );
>       this.addEventListener( "changeBackgroundColor", this._rwt_onChangeBackgoundColor, this );
>       this.addEventListener( "changeValue", this._rwt_onChangeValue, this );
>+      this.addEventListener( "changeEditable", this._rwt_onChangeEditable, this );
>       this._popup.addEventListener( "appear", this._rwt_onPopupAppear, this );
>       this._popup.addEventListener( "disappear", this._rwt_onPopupDisappear, this );
>     },
>@@ -35,6 +37,7 @@
>       this.removeEventListener( "changeTextColor", this._rwt_onChangeTextColor, this );
>       this.removeEventListener( "changeBackgroundColor", this._rwt_onChangeBackgoundColor, this );
>       this.removeEventListener( "changeValue", this._rwt_onChangeValue, this );
>+      this.removeEventListener( "changeEditable", this._rwt_onChangeEditable, this );
>       this._popup.removeEventListener( "appear", this._rwt_onPopupAppear, this );
>       this._popup.removeEventListener( "disappear", this._rwt_onPopupDisappear, this );
>     },
>@@ -118,7 +121,9 @@
>     _rwt_onPopupAppear : function( evt ) {
>       var f = this.getField();
>       f.setReadOnly( true );
>-      f.setCursor( "default" );
>+      if( this._userCursor == null ) {
>+        f.setCursor( "default" );
>+      }
>       f.setSelectable( false );
>     },
> 
>@@ -127,8 +132,23 @@
>       var editable = this.getEditable();
>       var f = this.getField();
>       f.setReadOnly( !editable );
>-      f.setCursor( editable ? null : "default" );
>+      if( this._userCursor == null ) {
>+        f.setCursor( editable ? null : "default" );
>+      }
>       f.setSelectable( editable );
>+    },
>+    
>+    _rwt_onChangeEditable : function( evt ) {
>+      if( this._userCursor != null ) {
>+        this.getField().setCursor( this._userCursor );
>+      }  
>+    },  
>+    
>+    setCursor : function( value ) {
>+      this._userCursor = value;
>+      this.getField().setCursor( value );
>+      this.getButton().setCursor( value );
>+      this.getList().setCursor( value );
>     }
> 
>   }
>Index: js/org/eclipse/swt/theme/AppearancesBase.js
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.rap/org.eclipse.rap.rwt.q07/js/org/eclipse/swt/theme/AppearancesBase.js,v
>retrieving revision 1.13
>diff -u -r1.13 AppearancesBase.js
>--- js/org/eclipse/swt/theme/AppearancesBase.js	25 Aug 2008 14:55:41 -0000	1.13
>+++ js/org/eclipse/swt/theme/AppearancesBase.js	26 Aug 2008 14:30:35 -0000
>@@ -764,6 +764,7 @@
>     style : function( states ) {
>       var tv = new org.eclipse.swt.theme.ThemeValues( states );
>       return {
>+        cursor : "default",
>         overflow : "hidden",
>         textColor : tv.getColor( "list.foreground" ),
>         backgroundColor : tv.getColor( "list.background" ),
>@@ -777,7 +778,7 @@
>     style : function( states ) {
>       var tv = new org.eclipse.swt.theme.ThemeValues( states );
>       var result = {
>-        cursor                  : "default",
>+//        cursor                  : "default",
>         height                  : "auto",
>         horizontalChildrenAlign : "left",
>         verticalChildrenAlign   : "middle",

Actions: View | Diff

Attachments on bug 244004: 110937 | 110938 | 110939 | 110940 | 111283 | 111284 | 111285