Attachment 110765 Details for Bug 244475 – a patch that fixed the problem

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] a patch that fixed the problem

clipboard.txt (text/plain), 3.56 KB, created by Jingwen 'Owen' Ou

on 2008-08-24 23:25:20 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jingwen 'Owen' Ou

Created: 2008-08-24 23:25:20 EDT

Size: 3.56 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/internal/tasks/ui/editors/EditorUtil.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/EditorUtil.java,v
>retrieving revision 1.16
>diff -u -r1.16 EditorUtil.java
>--- src/org/eclipse/mylyn/internal/tasks/ui/editors/EditorUtil.java	13 Aug 2008 05:41:54 -0000	1.16
>+++ src/org/eclipse/mylyn/internal/tasks/ui/editors/EditorUtil.java	25 Aug 2008 03:23:37 -0000
>@@ -168,6 +168,14 @@
> 	private static Control findControl(Composite composite, String key) {
> 		if (!composite.isDisposed()) {
> 			for (Control child : composite.getChildren()) {
>+				// expend subsections first
>+				if (child instanceof Section) {
>+					Section ex = (Section) child;
>+					if (!ex.isExpanded()) {
>+						toggleExpandableComposite(true, ex);
>+					}
>+				}
>+
> 				if (key.equals(getMarker(child))) {
> 					return child;
> 				}
>@@ -281,40 +289,46 @@
> 	 *            Whether or not the object should be highlighted.
> 	 */
> 	public static boolean reveal(ScrolledForm form, String key) {
>-		Control control = findControl(form.getBody(), key);
>-		if (control != null) {
>-			// expand all children
>-			if (control instanceof ExpandableComposite) {
>-				ExpandableComposite ex = (ExpandableComposite) control;
>-				if (!ex.isExpanded()) {
>-					toggleExpandableComposite(true, ex);
>-				}
>-			}
>+		try {
>+			form.setRedraw(false);
> 
>-			// expand all parents of control
>-			Composite comp = control.getParent();
>-			while (comp != null) {
>-				if (comp instanceof Section) {
>-					if (!((Section) comp).isExpanded()) {
>-						((Section) comp).setExpanded(true);
>-					}
>-				} else if (comp instanceof ExpandableComposite) {
>-					ExpandableComposite ex = (ExpandableComposite) comp;
>+			Control control = findControl(form.getBody(), key);
>+			if (control != null) {
>+				// expand all children
>+				if (control instanceof ExpandableComposite) {
>+					ExpandableComposite ex = (ExpandableComposite) control;
> 					if (!ex.isExpanded()) {
> 						toggleExpandableComposite(true, ex);
> 					}
>+				}
> 
>-					// HACK: This is necessary
>-					// due to a bug in SWT's ExpandableComposite.
>-					// 165803: Expandable bars should expand when clicking anywhere
>-					// https://bugs.eclipse.org/bugs/show_bug.cgi?taskId=165803
>-					if (ex.getData() != null && ex.getData() instanceof Composite) {
>-						((Composite) ex.getData()).setVisible(true);
>+				// expand all parents of control
>+				Composite comp = control.getParent();
>+				while (comp != null) {
>+					if (comp instanceof Section) {
>+						if (!((Section) comp).isExpanded()) {
>+							((Section) comp).setExpanded(true);
>+						}
>+					} else if (comp instanceof ExpandableComposite) {
>+						ExpandableComposite ex = (ExpandableComposite) comp;
>+						if (!ex.isExpanded()) {
>+							toggleExpandableComposite(true, ex);
>+						}
>+
>+						// HACK: This is necessary
>+						// due to a bug in SWT's ExpandableComposite.
>+						// 165803: Expandable bars should expand when clicking anywhere
>+						// https://bugs.eclipse.org/bugs/show_bug.cgi?taskId=165803
>+						if (ex.getData() != null && ex.getData() instanceof Composite) {
>+							((Composite) ex.getData()).setVisible(true);
>+						}
> 					}
>+					comp = comp.getParent();
> 				}
>-				comp = comp.getParent();
>+				focusOn(form, control);
> 			}
>-			focusOn(form, control);
>+		} finally {
>+			form.setRedraw(true);
> 		}
> 		return true;
> 	}

Actions: View | Diff

Attachments on bug 244475: 110290 | 110765 | 113057 | 113058