Attachment 110763 Details for Bug 244353 – a patch that uses Java Open Type dialog whne clicking the hyperlink

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] a patch that uses Java Open Type dialog whne clicking the hyperlink

clipboard.txt (text/plain), 3.81 KB, created by Jingwen 'Owen' Ou

on 2008-08-24 22:52:59 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jingwen 'Owen' Ou

Created: 2008-08-24 22:52:59 EDT

Size: 3.81 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.sandbox.ui
>Index: src/org/eclipse/mylyn/internal/sandbox/ui/hyperlinks/JavaResourceHyperlink.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/sandbox/org.eclipse.mylyn.sandbox.ui/src/org/eclipse/mylyn/internal/sandbox/ui/hyperlinks/JavaResourceHyperlink.java,v
>retrieving revision 1.4
>diff -u -r1.4 JavaResourceHyperlink.java
>--- src/org/eclipse/mylyn/internal/sandbox/ui/hyperlinks/JavaResourceHyperlink.java	21 Aug 2008 17:47:07 -0000	1.4
>+++ src/org/eclipse/mylyn/internal/sandbox/ui/hyperlinks/JavaResourceHyperlink.java	25 Aug 2008 02:51:31 -0000
>@@ -17,8 +17,6 @@
> import org.eclipse.core.runtime.Status;
> import org.eclipse.core.runtime.jobs.Job;
> import org.eclipse.debug.ui.IDebugModelPresentation;
>-import org.eclipse.jdt.core.IJavaProject;
>-import org.eclipse.jdt.core.IPackageFragment;
> import org.eclipse.jdt.core.IType;
> import org.eclipse.jdt.core.search.IJavaSearchConstants;
> import org.eclipse.jdt.core.search.SearchEngine;
>@@ -28,18 +26,15 @@
> import org.eclipse.jdt.core.search.SearchRequestor;
> import org.eclipse.jdt.internal.debug.ui.JDIDebugUIPlugin;
> import org.eclipse.jdt.internal.ui.JavaUIMessages;
>+import org.eclipse.jdt.internal.ui.dialogs.OpenTypeSelectionDialog;
> import org.eclipse.jdt.internal.ui.util.ExceptionHandler;
>-import org.eclipse.jdt.ui.JavaElementLabelProvider;
>-import org.eclipse.jdt.ui.JavaElementLabels;
> import org.eclipse.jdt.ui.JavaUI;
> import org.eclipse.jface.dialogs.IDialogConstants;
> import org.eclipse.jface.dialogs.MessageDialog;
> import org.eclipse.jface.text.IRegion;
> import org.eclipse.jface.text.hyperlink.IHyperlink;
>-import org.eclipse.jface.viewers.ArrayContentProvider;
> import org.eclipse.ui.IEditorInput;
> import org.eclipse.ui.PlatformUI;
>-import org.eclipse.ui.dialogs.ListDialog;
> import org.eclipse.ui.progress.UIJob;
> 
> /**
>@@ -127,7 +122,7 @@
> 			@Override
> 			public IStatus runInUIThread(IProgressMonitor monitor) {
> 				if (sources.size() > 1) {
>-					openTypeDialog(sources, typeName);
>+					openTypeDialog(typeName);
> 				} else if (sources.size() == 1 && sources.get(0) != null) {
> 					IType type = sources.get(0);
> 					processSearchResult(type, typeName);
>@@ -169,36 +164,15 @@
> 		}
> 	}
> 
>-	private void openTypeDialog(final List<IType> sources, final String typeName) {
>-		ListDialog dialog = new ListDialog(PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell());
>-		dialog.setInput(sources.toArray());
>-		dialog.setContentProvider(new ArrayContentProvider());
>-		dialog.setLabelProvider(new JavaElementLabelProvider() {
>-			@Override
>-			public String getText(Object element) {
>-				IType type = (IType) element;
>-				StringBuilder builder = new StringBuilder();
>-				builder.append(super.getText(type));
>-
>-				IPackageFragment fragment = type.getPackageFragment();
>-				if (fragment != null) {
>-					builder.append(JavaElementLabels.CONCAT_STRING);
>-					builder.append(super.getText(fragment));
>-				}
>-
>-				IJavaProject project = type.getJavaProject();
>-				if (project != null) {
>-					builder.append(JavaElementLabels.CONCAT_STRING);
>-					builder.append(super.getText(project));
>-				}
>-
>-				return builder.toString();
>-			}
>-		});
>+	private void openTypeDialog(final String typeName) {
>+		OpenTypeSelectionDialog dialog = new OpenTypeSelectionDialog(PlatformUI.getWorkbench()
>+				.getActiveWorkbenchWindow()
>+				.getShell(), true, PlatformUI.getWorkbench().getProgressService(), null, IJavaSearchConstants.TYPE);
> 
> 		dialog.setTitle("Open Hyperlink");
> 		dialog.setMessage("More than one types are detected, please select one:");
> 		dialog.setHelpAvailable(false);
>+		dialog.setInitialPattern(typeName);
> 
> 		int result = dialog.open();
> 		if (result != IDialogConstants.OK_ID) {

Actions: View | Diff

Attachments on bug 244353: 110182 | 110183 | 110184 | 110190 | 110763 | 113061