Attachment 110626 Details for Bug 243886 – modified patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] modified patch

bug243886 (text/plain), 3.77 KB, created by Phil Berkland

on 2008-08-21 17:49:49 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Phil Berkland

Created: 2008-08-21 17:49:49 EDT

Size: 3.77 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.wst.jsdt.core
>Index: src/org/eclipse/wst/jsdt/internal/compiler/problem/ProblemReporter.java
>===================================================================
>RCS file: /cvsroot/webtools/sourceediting/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/problem/ProblemReporter.java,v
>retrieving revision 1.26.6.1
>diff -u -r1.26.6.1 ProblemReporter.java
>--- src/org/eclipse/wst/jsdt/internal/compiler/problem/ProblemReporter.java	19 Jun 2008 20:05:56 -0000	1.26.6.1
>+++ src/org/eclipse/wst/jsdt/internal/compiler/problem/ProblemReporter.java	21 Aug 2008 21:49:11 -0000
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Michael Spector <spektom@gmail.com> -  Bug 243886
>  *******************************************************************************/
> package org.eclipse.wst.jsdt.internal.compiler.problem;
> 
>@@ -1115,7 +1116,12 @@
>  * to indicate that this problem is configurable through options
>  */
> public int computeSeverity(int problemID){
>+ 	
> 
>+	if (this.options.onlyReportSyntaxErrors && (problemID & IProblem.Syntax) == 0) {
>+		return ProblemSeverities.Ignore;
>+	}
>+	
> 	switch (problemID) {
> 		case IProblem.Task :
> 			return ProblemSeverities.Warning;
>Index: src/org/eclipse/wst/jsdt/internal/compiler/impl/CompilerOptions.java
>===================================================================
>RCS file: /cvsroot/webtools/sourceediting/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/impl/CompilerOptions.java,v
>retrieving revision 1.11
>diff -u -r1.11 CompilerOptions.java
>--- src/org/eclipse/wst/jsdt/internal/compiler/impl/CompilerOptions.java	30 Apr 2008 21:32:36 -0000	1.11
>+++ src/org/eclipse/wst/jsdt/internal/compiler/impl/CompilerOptions.java	21 Aug 2008 21:49:11 -0000
>@@ -357,11 +357,19 @@
> 	public InferOptions inferOptions=new InferOptions();
> 
> 
>+    public boolean onlyReportSyntaxErrors=false;
>+	
>+
> 	/**
> 	 * Initializing the compiler options with defaults
> 	 */
> 	public CompilerOptions(){
> 		// use default options
>+		try {
>+			this.onlyReportSyntaxErrors=JavaScriptCore.getPlugin().getPluginPreferences().getBoolean("onlySyntaxErrors");
>+		} catch (Exception ex) 
>+		{this.onlyReportSyntaxErrors=false;}
>+
> 	}
> 
> 	/**
>@@ -685,6 +693,11 @@
> 
> 	public void set(Map optionsMap) {
> 
>+		try {
>+			this.onlyReportSyntaxErrors=JavaScriptCore.getPlugin().getPluginPreferences().getBoolean("onlySyntaxErrors");
>+		} catch (Exception ex) 
>+		{this.onlyReportSyntaxErrors=false;}
>+
> 		Object optionValue;
> 		if ((optionValue = optionsMap.get(OPTION_LocalVariableAttribute)) != null) {
> 			if (GENERATE.equals(optionValue)) {
>Index: src/org/eclipse/wst/jsdt/internal/compiler/Compiler.java
>===================================================================
>RCS file: /cvsroot/webtools/sourceediting/plugins/org.eclipse.wst.jsdt.core/src/org/eclipse/wst/jsdt/internal/compiler/Compiler.java,v
>retrieving revision 1.16
>diff -u -r1.16 Compiler.java
>--- src/org/eclipse/wst/jsdt/internal/compiler/Compiler.java	13 May 2008 22:02:31 -0000	1.16
>+++ src/org/eclipse/wst/jsdt/internal/compiler/Compiler.java	21 Aug 2008 21:49:10 -0000
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Michael Spector <spektom@gmail.com> -  Bug 243886
>  *******************************************************************************/
> package org.eclipse.wst.jsdt.internal.compiler;
> 
>@@ -397,6 +398,9 @@
> 		CompilationUnitDeclaration unit,
> 		CompilationResult result) {
> 
>+		
>+		if (this.options.onlyReportSyntaxErrors)
>+			return;
> 		if ((result == null) && (unit != null)) {
> 			result = unit.compilationResult; // current unit being processed ?
> 		}

Actions: View | Diff

Attachments on bug 243886: 110584 | 110626 | 110751