Attachment 110268 Details for Bug 244457 – a patch fixed the problem

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] a patch fixed the problem

clipboard.txt (text/plain), 1.34 KB, created by Jingwen 'Owen' Ou

on 2008-08-18 13:57:32 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jingwen 'Owen' Ou

Created: 2008-08-18 13:57:32 EDT

Size: 1.34 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.sandbox.ui
>Index: src/org/eclipse/mylyn/internal/sandbox/ui/editors/CommentGroupStrategy.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/sandbox/org.eclipse.mylyn.sandbox.ui/src/org/eclipse/mylyn/internal/sandbox/ui/editors/CommentGroupStrategy.java,v
>retrieving revision 1.1
>diff -u -r1.1 CommentGroupStrategy.java
>--- src/org/eclipse/mylyn/internal/sandbox/ui/editors/CommentGroupStrategy.java	18 Aug 2008 04:33:21 -0000	1.1
>+++ src/org/eclipse/mylyn/internal/sandbox/ui/editors/CommentGroupStrategy.java	18 Aug 2008 17:53:20 -0000
>@@ -60,7 +60,7 @@
> 		List<CommentGroup> commentGroups = new ArrayList<CommentGroup>();
> 		List<TaskAttribute> comments = new ArrayList<TaskAttribute>();
> 
>-		int recentFromIndex = 0, currentFromIndex = 0;
>+		int recentFromIndex = -1, currentFromIndex = -1;
> 		String currentPersonId = taskDataModel.getTaskRepository().getUserName();
> 
> 		// current
>@@ -88,7 +88,7 @@
> 		}
> 
> 		// group by last author
>-		if (currentFromIndex < comments.size()) {
>+		if (currentFromIndex != -1 && currentFromIndex < comments.size()) {
> 			current.addAll(0, new ArrayList<TaskAttribute>(comments.subList(currentFromIndex, comments.size())));
> 			if (current.size() > 0) {
> 				comments.removeAll(current);

Actions: View | Diff

Attachments on bug 244457: 110268