Attachment 110190 Details for Bug 244353 – a patch disables converting move to copy in TaskEdtiorDropTarget

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] a patch disables converting move to copy in TaskEdtiorDropTarget

clipboard.txt (text/plain), 2.16 KB, created by Jingwen 'Owen' Ou

on 2008-08-18 00:19:59 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jingwen 'Owen' Ou

Created: 2008-08-18 00:19:59 EDT

Size: 2.16 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.sandbox.ui
>Index: src/org/eclipse/mylyn/internal/sandbox/ui/editors/TaskEditorDropTarget.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/sandbox/org.eclipse.mylyn.sandbox.ui/src/org/eclipse/mylyn/internal/sandbox/ui/editors/TaskEditorDropTarget.java,v
>retrieving revision 1.1
>diff -u -r1.1 TaskEditorDropTarget.java
>--- src/org/eclipse/mylyn/internal/sandbox/ui/editors/TaskEditorDropTarget.java	16 Aug 2008 06:19:26 -0000	1.1
>+++ src/org/eclipse/mylyn/internal/sandbox/ui/editors/TaskEditorDropTarget.java	18 Aug 2008 04:18:32 -0000
>@@ -48,7 +48,9 @@
> 		super(editor.getTextWidget());
> 		this.editor = editor;
> 
>-		DropTarget target = new DropTarget(editor.getControl(), DND.DROP_COPY | DND.DROP_MOVE);
>+		// move can't be converted to copy in Linux, bug 244353 comment 10
>+		// DropTarget target = new DropTarget(editor.getControl(), DND.DROP_COPY | DND.DROP_MOVE);
>+		DropTarget target = new DropTarget(editor.getControl(), DND.DROP_COPY);
> 		// TODO: may also add TaskTransfer?
> 		// TODO: this concern may also go to IResourceHyperlinkExtension by adding something like IResourceHyperlinkExtension.getTransfers()?
> 		target.setTransfer(new Transfer[] { JavaUI.getJavaElementClipboardTransfer(), ResourceTransfer.getInstance(),
>@@ -57,17 +59,19 @@
> 
> 	}
> 
>-	@Override
>-	public void dragEnter(DropTargetEvent event) {
>-		if (event.detail == DND.DROP_MOVE || event.detail == DND.DROP_DEFAULT) {
>-			if ((event.operations & DND.DROP_COPY) != 0) {
>-				event.detail = DND.DROP_COPY;
>-			} else {
>-				event.detail = DND.DROP_NONE;
>-			}
>-		}
>-		super.dragEnter(event);
>-	}
>+// move can't be converted to copy in Linux, bug 244353 comment 10
>+//	@Override
>+//	public void dragEnter(DropTargetEvent event) {
>+//		
>+//		//if (event.detail == DND.DROP_MOVE || event.detail == DND.DROP_DEFAULT) {
>+//		if ((event.operations & DND.DROP_COPY) != 0) {
>+//			event.detail = DND.DROP_COPY;
>+//		} else {
>+//			event.detail = DND.DROP_NONE;
>+//		}
>+//		//}
>+//		super.dragEnter(event);
>+//	}
> 
> 	@Override
> 	public void drop(DropTargetEvent event) {

Actions: View | Diff

Attachments on bug 244353: 110182 | 110183 | 110184 | 110190 | 110763 | 113061