Attachment 110185 Details for Bug 244387 – memory leak patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] memory leak patch

zest-memory-leak.patch (text/plain), 2.48 KB, created by Lars Grammel

on 2008-08-17 21:05:25 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Lars Grammel

Created: 2008-08-17 21:05:25 EDT

Size: 2.48 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.zest.core
>Index: src/org/eclipse/zest/core/viewers/internal/AbstractStructuredGraphViewer.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.gef/plugins/org.eclipse.zest.core/src/org/eclipse/zest/core/viewers/internal/AbstractStructuredGraphViewer.java,v
>retrieving revision 1.10
>diff -u -r1.10 AbstractStructuredGraphViewer.java
>--- src/org/eclipse/zest/core/viewers/internal/AbstractStructuredGraphViewer.java	12 Sep 2007 20:44:39 -0000	1.10
>+++ src/org/eclipse/zest/core/viewers/internal/AbstractStructuredGraphViewer.java	18 Aug 2008 00:57:50 -0000
>@@ -644,7 +643,8 @@
> 	 *            The node element to remove.
> 	 */
> 	public void removeNode(Object element) {
>-		GraphNode node = (GraphNode) nodesMap.get(element);
>+		// remove the node from the nodes map to prevent memory leak
>+		GraphNode node = (GraphNode) nodesMap.remove(element);
> 
> 		if (node != null) {
> 			// remove the node from the layout algorithm and all the connections
>Index: src/org/eclipse/zest/core/viewers/internal/AbstractStylingModelFactory.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.gef/plugins/org.eclipse.zest.core/src/org/eclipse/zest/core/viewers/internal/AbstractStylingModelFactory.java,v
>retrieving revision 1.9
>diff -u -r1.9 AbstractStylingModelFactory.java
>--- src/org/eclipse/zest/core/viewers/internal/AbstractStylingModelFactory.java	12 Sep 2007 20:44:39 -0000	1.9
>+++ src/org/eclipse/zest/core/viewers/internal/AbstractStylingModelFactory.java	18 Aug 2008 00:57:50 -0000
>@@ -295,6 +294,7 @@
> 	 */
> 	public void clearGraph(Graph graph) {
> 		graph.setSelection(null);
>+		graph.clear();
> 		Object[] nodeElements = viewer.getNodeElements();
> 		for (int i = 0; i < nodeElements.length; i++) {
> 			viewer.removeGraphModelNode(nodeElements[i]);
>Index: src/org/eclipse/zest/core/widgets/Graph.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.gef/plugins/org.eclipse.zest.core/src/org/eclipse/zest/core/widgets/Graph.java,v
>retrieving revision 1.37
>diff -u -r1.37 Graph.java
>--- src/org/eclipse/zest/core/widgets/Graph.java	17 Jun 2008 05:48:40 -0000	1.37
>+++ src/org/eclipse/zest/core/widgets/Graph.java	18 Aug 2008 00:57:56 -0000
>@@ -1169,4 +1176,8 @@
> 		return (GraphItem) figure2ItemMap.get(figure);
> 	}
> 
>+	public void clear() {
>+		figure2ItemMap.clear();
>+	}
>+
> }

Actions: View | Diff

Attachments on bug 244387: 110185 | 114855