Attachment 109875 Details for Bug 240463 – Patch to WebUtil to not overwrite JCL System properties set with -D on Java command line.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch to WebUtil to not overwrite JCL System properties set with -D on Java command line.

WebUtil_respectExistingJCLSystemProprtySettings.patch.txt (text/plain), 2.45 KB, created by Mark Kralj-Taylor

on 2008-08-13 04:59:46 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Kralj-Taylor

Created: 2008-08-13 04:59:46 EDT

Size: 2.45 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.commons.net
>Index: src/org/eclipse/mylyn/commons/net/WebUtil.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.commons.net/src/org/eclipse/mylyn/commons/net/WebUtil.java,v
>retrieving revision 1.6
>diff -u -r1.6 WebUtil.java
>--- src/org/eclipse/mylyn/commons/net/WebUtil.java	18 Jun 2008 22:14:45 -0000	1.6
>+++ src/org/eclipse/mylyn/commons/net/WebUtil.java	13 Aug 2008 08:32:12 -0000
>@@ -549,12 +549,36 @@
> 		// initialization is done in the static initializer		
> 	}
> 
>+	/**
>+	 * Defaults org.apache.commons.logging system properties.
>+	 * <p>
>+	 * Only sets System properties if they are NOT already set to a value.
>+	 * </p>
>+	 * <p>
>+	 * For example adding this to your Eclipse Java launch command line enables verbose Mylyn wire logging:
>+	 * 
>+	 * <pre>
>+	 * 
>+	 * -Dorg.apache.commons.logging.Log=org.apache.commons.logging.impl.SimpleLog
>+	 * -Dorg.apache.commons.logging.simplelog.showlogname=true -Dorg.apache.commons.logging.simplelog.defaultlog=off
>+	 * -Dorg.apache.commons.logging.simplelog.log.httpclient.wire=debug
>+	 * -Dorg.apache.commons.logging.simplelog.log.org.apache.commons.httpclient=off
>+	 * -Dorg.apache.commons.logging.simplelog.log.org.apache.axis.message=debug
>+	 * 
>+	 * </pre>
>+	 * </p>
>+	 */
> 	private static void initCommonsLoggingSettings() {
>-		// remove?
>-		System.setProperty("org.apache.commons.logging.Log", "org.apache.commons.logging.impl.SimpleLog");
>-		System.setProperty("org.apache.commons.logging.simplelog.defaultlog", "off");
>-		System.setProperty("org.apache.commons.logging.simplelog.log.httpclient.wire.header", "off");
>-		System.setProperty("org.apache.commons.logging.simplelog.log.org.apache.commons.httpclient", "off");
>+		defaultSystemProperty("org.apache.commons.logging.Log", "org.apache.commons.logging.impl.SimpleLog");
>+		defaultSystemProperty("org.apache.commons.logging.simplelog.defaultlog", "off");
>+		defaultSystemProperty("org.apache.commons.logging.simplelog.log.httpclient.wire.header", "off");
>+		defaultSystemProperty("org.apache.commons.logging.simplelog.log.org.apache.commons.httpclient", "off");
>+	}
>+
>+	private static void defaultSystemProperty(String key, String defaultValue) {
>+		if (System.getProperty(key) == null) {
>+			System.setProperty(key, defaultValue);
>+		}
> 	}
> 
> 	private static boolean isRepositoryHttps(String repositoryUrl) {

Actions: View | Diff

Attachments on bug 240463: 109874 | 109875